From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511B5C5479D for ; Tue, 10 Jan 2023 00:04:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235560AbjAJAD7 (ORCPT ); Mon, 9 Jan 2023 19:03:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234480AbjAJAD6 (ORCPT ); Mon, 9 Jan 2023 19:03:58 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E6F81095; Mon, 9 Jan 2023 16:03:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4EC1DB807E9; Tue, 10 Jan 2023 00:03:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EE06C433D2; Tue, 10 Jan 2023 00:03:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673309035; bh=OaLzYnvyIIb5IEz5HQgHMyamldsrvh2YVOvR3GSiTMo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=omxAb8kWHSVWvLrdP8zDS3ppGYk/t5v2pIbPHqv2ELf5hrjgTvWjBzCflENYCgbjU K99w7QGJ2j+Tc/XwdtSFbqTNA36Bs6MoWCTzmpla3o/c56f+e44Tfgz9wSt1OMlBuO 3lAREFhf8EcPenIScZbf/c8BRp2HHgEzwNnDlHTwiY/gVyfB/oInDRWSSTfaCUfGoB o/cB/vKOJM7HP8D18Xe/+EXJJLtoZ0Pm/t0UONFug1bI/1ZMAkf4f19Y5xajAklPWV Ho5mC+Kw0ranX6eEQFkJTFKGgDlzLaHh2mGHu2uUEBG+oMBmrmpoS9Jz3IMM3AXOeF QqOn68Yfd8NKw== Date: Tue, 10 Jan 2023 09:03:51 +0900 From: Masami Hiramatsu (Google) To: Cc: , , , , Subject: Re: [PATCH linux-next] tracing: use strscpy() to instead of strncpy() Message-Id: <20230110090351.e3c80a1f7a36ac897ddc3746@kernel.org> In-Reply-To: <202301091939219689840@zte.com.cn> References: <202301091939219689840@zte.com.cn> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, 9 Jan 2023 19:39:21 +0800 (CST) wrote: > From: Xu Panda > > The implementation of strscpy() is more robust and safer. > That's now the recommended way to copy NUL-terminated strings. This looks good to me. Acked-by: Masami Hiramatsu (Google) Thank you, > > Signed-off-by: Xu Panda > Signed-off-by: Yang Yang > --- > kernel/trace/trace_events_synth.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c > index 67592eed0be8..cd636edd045e 100644 > --- a/kernel/trace/trace_events_synth.c > +++ b/kernel/trace/trace_events_synth.c > @@ -195,8 +195,7 @@ static int synth_field_string_size(char *type) > if (len == 0) > return 0; /* variable-length string */ > > - strncpy(buf, start, len); > - buf[len] = '\0'; > + strscpy(buf, start, len + 1); > > err = kstrtouint(buf, 0, &size); > if (err) > -- > 2.15.2 -- Masami Hiramatsu (Google)