From: Steven Rostedt <rostedt@goodmis.org>
To: Ross Zwisler <zwisler@google.com>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/4] tracing: Add trace_array_puts() to write into instance
Date: Thu, 12 Jan 2023 19:00:30 -0500 [thread overview]
Message-ID: <20230112190030.0c1fc121@gandalf.local.home> (raw)
In-Reply-To: <Y8CXI1h9hsPeiu6u@google.com>
On Thu, 12 Jan 2023 16:26:27 -0700
Ross Zwisler <zwisler@google.com> wrote:
> > +/**
> > + * trace_array_puts - write a constant string into the trace buffer.
> > + * @tr: The trace array to write to
> > + * @ip: The address of the caller
>
> @ip is not an arg to trace_array_puts(), an can be dropped from the comment.
Good catch.
My first version had it, and then I realized I didn't like it (to be in
sync with the internal version of __trace_puts()". But I forgot to update
the kernel doc. Thanks for pointing that out.
>
> Other than that, you can add:
>
> Reviewed-by: Ross Zwisler <zwisler@google.com>
Thanks,
-- Steve
next prev parent reply other threads:[~2023-01-13 0:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 14:56 [PATCH 0/4] tracing: Addition of tracing instances via kernel command line Steven Rostedt
2023-01-11 14:56 ` [PATCH 1/4] tracing: Add creation of instances at boot " Steven Rostedt
2023-01-11 16:33 ` Randy Dunlap
2023-01-12 23:24 ` Ross Zwisler
2023-01-12 23:59 ` Steven Rostedt
2023-01-11 14:56 ` [PATCH 2/4] tracing: Add enabling of events to boot instances Steven Rostedt
2023-01-12 23:24 ` Ross Zwisler
2023-01-11 14:56 ` [PATCH 3/4] tracing: Add trace_array_puts() to write into instance Steven Rostedt
2023-01-12 23:26 ` Ross Zwisler
2023-01-13 0:00 ` Steven Rostedt [this message]
2023-01-11 14:56 ` [PATCH 4/4] tracing: Allow boot instances to have snapshot buffers Steven Rostedt
2023-01-11 20:03 ` kernel test robot
2023-01-11 21:34 ` kernel test robot
2023-01-11 23:05 ` kernel test robot
2023-01-11 23:45 ` kernel test robot
2023-01-14 0:08 ` Ross Zwisler
2023-01-14 4:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112190030.0c1fc121@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).