From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linyu Yuan <quic_linyyuan@quicinc.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org
Subject: [PATCH 0/2] tracing: Have bpf and perf reuse the tracefs TRACE_EVENT macros
Date: Tue, 24 Jan 2023 15:22:38 -0500 [thread overview]
Message-ID: <20230124202238.563854686@goodmis.org> (raw)
When reviewing Linyu Yuan patches[1] where the change was to move most
the macros from perf and bpf into stages, I realized that the macros
that makes up perf and bpf events are duplicated from the tracefs
macros that were moved into the stages directory. One reason to move
them into that directory was to remove duplicate code.
Remove the macros that are duplicated in the bpf and perf code and use
stage 6, which is the macros used to build the data needed to record
the TRACE_EVENT() TP_fast_assign() into the trace. This will mean they
will pick up bug fixes, as well as any enhacements that are added.
[1] https://lore.kernel.org/lkml/1671181385-5719-1-git-send-email-quic_linyyuan@quicinc.com/
Steven Rostedt (Google) (2):
perf/tracing: Use stage6 of tracing to not duplicate macros
bpf/tracing: Use stage6 of tracing to not duplicate macros
----
include/trace/bpf_probe.h | 45 +--------------------------
include/trace/perf.h | 46 +---------------------------
include/trace/stages/stage6_event_callback.h | 3 ++
3 files changed, 5 insertions(+), 89 deletions(-)
next reply other threads:[~2023-01-24 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 20:22 Steven Rostedt [this message]
2023-01-24 20:22 ` [PATCH 1/2] perf/tracing: Use stage6 of tracing to not duplicate macros Steven Rostedt
2023-01-25 9:16 ` Peter Zijlstra
2023-01-24 20:22 ` [PATCH 2/2] bpf/tracing: " Steven Rostedt
2023-01-24 21:11 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124202238.563854686@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=quic_linyyuan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).