* [PATCH -next] tracing: clean up some inconsistent indentings
@ 2023-01-31 6:19 Yang Li
2023-01-31 14:46 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-01-31 6:19 UTC (permalink / raw)
To: rostedt; +Cc: mhiramat, linux-kernel, linux-trace-kernel, Yang Li, Abaci Robot
kernel/trace/trace_events_synth.c:567 trace_event_raw_event_synth() warn: inconsistent indenting
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3892
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
kernel/trace/trace_events_synth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
index adb630633f31..949d4cbe3f82 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/trace/trace_events_synth.c
@@ -564,7 +564,8 @@ static notrace void trace_event_raw_event_synth(void *__data,
event->fields[i]->is_dynamic,
data_size, &n_u64);
data_size += len; /* only dynamic string increments */
- } if (event->fields[i]->is_stack) {
+ }
+ if (event->fields[i]->is_stack) {
long *stack = (long *)(long)var_ref_vals[val_idx];
len = trace_stack(entry, event, stack,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] tracing: clean up some inconsistent indentings
2023-01-31 6:19 [PATCH -next] tracing: clean up some inconsistent indentings Yang Li
@ 2023-01-31 14:46 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2023-01-31 14:46 UTC (permalink / raw)
To: Yang Li; +Cc: mhiramat, linux-kernel, linux-trace-kernel, Abaci Robot
On Tue, 31 Jan 2023 14:19:35 +0800
Yang Li <yang.lee@linux.alibaba.com> wrote:
> kernel/trace/trace_events_synth.c:567 trace_event_raw_event_synth() warn: inconsistent indenting
>
NACK!
This just removes the warning and hence it hides the bug!
This was already reported by kernel test robot:
https://lore.kernel.org/all/202301302110.mEtNwkBD-lkp@intel.com/
I have a fix but haven't posted it yet.
-- Steve
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3892
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> kernel/trace/trace_events_synth.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
> index adb630633f31..949d4cbe3f82 100644
> --- a/kernel/trace/trace_events_synth.c
> +++ b/kernel/trace/trace_events_synth.c
> @@ -564,7 +564,8 @@ static notrace void trace_event_raw_event_synth(void *__data,
> event->fields[i]->is_dynamic,
> data_size, &n_u64);
> data_size += len; /* only dynamic string increments */
> - } if (event->fields[i]->is_stack) {
> + }
> + if (event->fields[i]->is_stack) {
> long *stack = (long *)(long)var_ref_vals[val_idx];
>
> len = trace_stack(entry, event, stack,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-31 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-31 6:19 [PATCH -next] tracing: clean up some inconsistent indentings Yang Li
2023-01-31 14:46 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).