From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Anton Gusev <aagusev@ispras.ru>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c
Date: Wed, 1 Feb 2023 00:37:53 +0900 [thread overview]
Message-ID: <20230201003753.d844d26d902169ee64b979d4@kernel.org> (raw)
In-Reply-To: <20230131075818.5322-1-aagusev@ispras.ru>
On Tue, 31 Jan 2023 10:58:18 +0300
Anton Gusev <aagusev@ispras.ru> wrote:
> Overwriting the error code with the deletion result may cause the
> function to return 0 despite encountering an error. Commit b111545d26c0
> ("tracing: Remove the useless value assignment in
> test_create_synth_event()") solves a similar issue by
> returning the original error code, so this patch does the same.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Anton Gusev <aagusev@ispras.ru>
Oops, thanks for the fix!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> kernel/trace/kprobe_event_gen_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/kprobe_event_gen_test.c b/kernel/trace/kprobe_event_gen_test.c
> index c736487fc0e4..e0c420eb0b2b 100644
> --- a/kernel/trace/kprobe_event_gen_test.c
> +++ b/kernel/trace/kprobe_event_gen_test.c
> @@ -146,7 +146,7 @@ static int __init test_gen_kprobe_cmd(void)
> if (trace_event_file_is_valid(gen_kprobe_test))
> gen_kprobe_test = NULL;
> /* We got an error after creating the event, delete it */
> - ret = kprobe_event_delete("gen_kprobe_test");
> + kprobe_event_delete("gen_kprobe_test");
> goto out;
> }
>
> @@ -211,7 +211,7 @@ static int __init test_gen_kretprobe_cmd(void)
> if (trace_event_file_is_valid(gen_kretprobe_test))
> gen_kretprobe_test = NULL;
> /* We got an error after creating the event, delete it */
> - ret = kprobe_event_delete("gen_kretprobe_test");
> + kprobe_event_delete("gen_kretprobe_test");
> goto out;
> }
>
> --
> 2.39.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-01-31 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 7:58 [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c Anton Gusev
2023-01-31 15:13 ` Steven Rostedt
2023-01-31 15:37 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201003753.d844d26d902169ee64b979d4@kernel.org \
--to=mhiramat@kernel.org \
--cc=aagusev@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox