From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Qing Zhang <zhangqing@loongson.cn>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuah@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/ftrace: add LoongArch support for kprobe args string tests
Date: Mon, 13 Feb 2023 08:29:17 +0900 [thread overview]
Message-ID: <20230213082917.68a4fde41f1143fd32c6111b@kernel.org> (raw)
In-Reply-To: <20230211084346.25941-1-zhangqing@loongson.cn>
On Sat, 11 Feb 2023 16:43:46 +0800
Qing Zhang <zhangqing@loongson.cn> wrote:
> before:
> [5] Kprobe event string type argument [UNTESTED]
> [7] Kprobe event argument syntax [UNTESTED]
> after:
> [5] Kprobe event string type argument [PASS]
> [7] Kprobe event argument syntax [PASS]
>
Thanks for updating the test!
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 3 +++
> .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index 459741565222..a4f8e7c53c1f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -28,6 +28,9 @@ s390*)
> mips*)
> ARG1=%r4
> ;;
> +loongarch*)
> + ARG1=%r4
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> index d4662c8cf407..1df61e13a812 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> @@ -40,6 +40,10 @@ mips*)
> GOODREG=%r4
> BADREG=%r12
> ;;
> +loongarch*)
> + GOODREG=%r4
> + BADREG=%r12
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> --
> 2.36.0
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-02-12 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 8:43 [PATCH] selftests/ftrace: add LoongArch support for kprobe args string tests Qing Zhang
2023-02-11 11:13 ` Huacai Chen
2023-02-12 23:29 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213082917.68a4fde41f1143fd32c6111b@kernel.org \
--to=mhiramat@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).