From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Tom Rix <trix@redhat.com>
Cc: rostedt@goodmis.org, bristot@kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/osnoise: set several trace_osnoise.c variables storage-class-specifier to static
Date: Fri, 10 Mar 2023 14:24:00 +0900 [thread overview]
Message-ID: <20230310142400.072ce534ddec8e375e8dfa99@kernel.org> (raw)
In-Reply-To: <20230309150414.4036764-1-trix@redhat.com>
On Thu, 9 Mar 2023 10:04:14 -0500
Tom Rix <trix@redhat.com> wrote:
> smatch reports several similar warnings
> kernel/trace/trace_osnoise.c:220:1: warning:
> symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static?
> kernel/trace/trace_osnoise.c:243:1: warning:
> symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
> kernel/trace/trace_osnoise.c:335:14: warning:
> symbol 'interface_lock' was not declared. Should it be static?
> kernel/trace/trace_osnoise.c:2242:5: warning:
> symbol 'timerlat_min_period' was not declared. Should it be static?
> kernel/trace/trace_osnoise.c:2243:5: warning:
> symbol 'timerlat_max_period' was not declared. Should it be static?
>
> These variables are only used in trace_osnoise.c, so it should be static
>
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> kernel/trace/trace_osnoise.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
> index f68ca1e6460f..cf395d2e8775 100644
> --- a/kernel/trace/trace_osnoise.c
> +++ b/kernel/trace/trace_osnoise.c
> @@ -217,7 +217,7 @@ struct osnoise_variables {
> /*
> * Per-cpu runtime information.
> */
> -DEFINE_PER_CPU(struct osnoise_variables, per_cpu_osnoise_var);
> +static DEFINE_PER_CPU(struct osnoise_variables, per_cpu_osnoise_var);
>
> /*
> * this_cpu_osn_var - Return the per-cpu osnoise_variables on its relative CPU
> @@ -240,7 +240,7 @@ struct timerlat_variables {
> u64 count;
> };
>
> -DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var);
> +static DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var);
>
> /*
> * this_cpu_tmr_var - Return the per-cpu timerlat_variables on its relative CPU
> @@ -332,7 +332,7 @@ struct timerlat_sample {
> /*
> * Protect the interface.
> */
> -struct mutex interface_lock;
> +static struct mutex interface_lock;
>
> /*
> * Tracer data.
> @@ -2239,8 +2239,8 @@ static struct trace_min_max_param osnoise_print_stack = {
> /*
> * osnoise/timerlat_period: min 100 us, max 1 s
> */
> -u64 timerlat_min_period = 100;
> -u64 timerlat_max_period = 1000000;
> +static u64 timerlat_min_period = 100;
> +static u64 timerlat_max_period = 1000000;
> static struct trace_min_max_param timerlat_period = {
> .lock = &interface_lock,
> .val = &osnoise_data.timerlat_period,
> --
> 2.27.0
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-03-10 5:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 15:04 [PATCH] tracing/osnoise: set several trace_osnoise.c variables storage-class-specifier to static Tom Rix
2023-03-10 5:24 ` Masami Hiramatsu [this message]
2023-03-10 13:53 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310142400.072ce534ddec8e375e8dfa99@kernel.org \
--to=mhiramat@kernel.org \
--cc=bristot@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).