From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org,
Heinz Wiesinger <pprkut@slackware.com>,
andersson@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_rjendra@quicinc.com, quic_saipraka@quicinc.com,
quic_sibis@quicinc.com
Subject: Re: [PATCH] bootconfig: Fix testcase to increase max node
Date: Wed, 15 Mar 2023 16:59:05 +0900 [thread overview]
Message-ID: <20230315165905.4bb2a464b2ffe4fb640cfbdd@kernel.org> (raw)
In-Reply-To: <20230314111213.08f33839@gandalf.local.home>
On Tue, 14 Mar 2023 11:12:13 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 13 Mar 2023 22:56:09 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > @@ -87,10 +88,16 @@ xfail grep -i "error" $OUTFILE
> >
> > echo "Max node number check"
> >
> > -echo -n > $TEMPCONF
> > -for i in `seq 1 1024` ; do
> > - echo "node$i" >> $TEMPCONF
>
> Do you need this extra file?
>
> > -done
> > +cat > $AWKFILE << EOF
> > +BEGIN {
> > + for (i = 0; i < 26; i += 1)
> > + printf("%c\n", 65 + i % 26)
> > + for (i = 26; i < 8192; i += 1)
> > + printf("%c%c%c\n", 65 + i % 26, 65 + (i / 26) % 26, 65 + (i / 26 / 26))
> > +}
> > +EOF
> > +awk -f "$AWKFILE" > $TEMPCONF
>
> Couldn't the above just be:
>
> awk '
> BEGIN {
> for (i = 0; i < 26; i += 1)
> printf("%c\n", 65 + i % 26)
> for (i = 26; i < 8192; i += 1)
> printf("%c%c%c\n", 65 + i % 26, 65 + (i / 26) % 26, 65 + (i / 26 / 26))
> }
> ' > $TEMPCONF
>
> and not need the extra file?
Indeed. Let me update this.
Thank you!
>
> -- Steve
>
>
> > xpass $BOOTCONF -a $TEMPCONF $INITRD
> >
> > echo "badnode" >> $TEMPCONF
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-03-15 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 13:56 [PATCH] bootconfig: Fix testcase to increase max node Masami Hiramatsu (Google)
2023-03-14 15:12 ` Steven Rostedt
2023-03-15 7:59 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315165905.4bb2a464b2ffe4fb640cfbdd@kernel.org \
--to=mhiramat@kernel.org \
--cc=andersson@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=pprkut@slackware.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_saipraka@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).