Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value

[Gildong Hong <roaming2man@gmail.com>]

On Thu, Mar 16, 2023 at 10:11:37AM -0400, Steven Rostedt wrote:
> On Thu, 16 Mar 2023 20:56:55 +0900
> Gildong Hong <roaming2man@gmail.com> wrote:
> 
> > vruntime is not actual time so remove unit on printing
> > 
> > Signed-off-by: Gildong Hong <roaming2man@gmail.com>
> > ---
> >  include/trace/events/sched.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> > index fbb99a61f714..26ef85a8d3cd 100644
> > --- a/include/trace/events/sched.h
> > +++ b/include/trace/events/sched.h
> > @@ -511,7 +511,7 @@ DECLARE_EVENT_CLASS(sched_stat_runtime,
> >  		__entry->vruntime	= vruntime;
> >  	),
> >  
> > -	TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
> > +	TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
> 
> What about calling it "[vns]" for "virtual nanosecond" ?
> 
> ;-)
> 
> -- Steve
> 
> >  			__entry->comm, __entry->pid,
> >  			(unsigned long long)__entry->runtime,
> >  			(unsigned long long)__entry->vruntime)
> 

Dear Steve

"vns" sounds nice.
But some people may hard to understand the meaning.
"ns" is a global standard time unit where "vns" is not.
So I still prefer to remove the unit.

Thanks for your review.
Gildong