* [PATCH] trace/events/sched: Remove unit on printing vruntime value
@ 2023-03-16 11:56 Gildong Hong
2023-03-16 14:11 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: Gildong Hong @ 2023-03-16 11:56 UTC (permalink / raw)
To: rostedt, mhiramat, delyank, peterz; +Cc: linux-trace-kernel, Gildong Hong
vruntime is not actual time so remove unit on printing
Signed-off-by: Gildong Hong <roaming2man@gmail.com>
---
include/trace/events/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index fbb99a61f714..26ef85a8d3cd 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -511,7 +511,7 @@ DECLARE_EVENT_CLASS(sched_stat_runtime,
__entry->vruntime = vruntime;
),
- TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
+ TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
__entry->comm, __entry->pid,
(unsigned long long)__entry->runtime,
(unsigned long long)__entry->vruntime)
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value
2023-03-16 11:56 [PATCH] trace/events/sched: Remove unit on printing vruntime value Gildong Hong
@ 2023-03-16 14:11 ` Steven Rostedt
2023-03-19 3:05 ` Gildong Hong
0 siblings, 1 reply; 7+ messages in thread
From: Steven Rostedt @ 2023-03-16 14:11 UTC (permalink / raw)
To: Gildong Hong; +Cc: mhiramat, delyank, peterz, linux-trace-kernel
On Thu, 16 Mar 2023 20:56:55 +0900
Gildong Hong <roaming2man@gmail.com> wrote:
> vruntime is not actual time so remove unit on printing
>
> Signed-off-by: Gildong Hong <roaming2man@gmail.com>
> ---
> include/trace/events/sched.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> index fbb99a61f714..26ef85a8d3cd 100644
> --- a/include/trace/events/sched.h
> +++ b/include/trace/events/sched.h
> @@ -511,7 +511,7 @@ DECLARE_EVENT_CLASS(sched_stat_runtime,
> __entry->vruntime = vruntime;
> ),
>
> - TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
> + TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
What about calling it "[vns]" for "virtual nanosecond" ?
;-)
-- Steve
> __entry->comm, __entry->pid,
> (unsigned long long)__entry->runtime,
> (unsigned long long)__entry->vruntime)
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value
2023-03-16 14:11 ` Steven Rostedt
@ 2023-03-19 3:05 ` Gildong Hong
2023-03-19 18:07 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: Gildong Hong @ 2023-03-19 3:05 UTC (permalink / raw)
To: Steven Rostedt; +Cc: mhiramat, delyank, peterz, linux-trace-kernel
On Thu, Mar 16, 2023 at 10:11:37AM -0400, Steven Rostedt wrote:
> On Thu, 16 Mar 2023 20:56:55 +0900
> Gildong Hong <roaming2man@gmail.com> wrote:
>
> > vruntime is not actual time so remove unit on printing
> >
> > Signed-off-by: Gildong Hong <roaming2man@gmail.com>
> > ---
> > include/trace/events/sched.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> > index fbb99a61f714..26ef85a8d3cd 100644
> > --- a/include/trace/events/sched.h
> > +++ b/include/trace/events/sched.h
> > @@ -511,7 +511,7 @@ DECLARE_EVENT_CLASS(sched_stat_runtime,
> > __entry->vruntime = vruntime;
> > ),
> >
> > - TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
> > + TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
>
> What about calling it "[vns]" for "virtual nanosecond" ?
>
> ;-)
>
> -- Steve
>
> > __entry->comm, __entry->pid,
> > (unsigned long long)__entry->runtime,
> > (unsigned long long)__entry->vruntime)
>
Dear Steve
"vns" sounds nice.
But some people may hard to understand the meaning.
"ns" is a global standard time unit where "vns" is not.
So I still prefer to remove the unit.
Thanks for your review.
Gildong
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value
2023-03-19 3:05 ` Gildong Hong
@ 2023-03-19 18:07 ` Steven Rostedt
2023-03-20 11:41 ` Gildong Hong
2023-03-20 11:41 ` Peter Zijlstra
0 siblings, 2 replies; 7+ messages in thread
From: Steven Rostedt @ 2023-03-19 18:07 UTC (permalink / raw)
To: Gildong Hong; +Cc: mhiramat, delyank, peterz, linux-trace-kernel
On Sun, 19 Mar 2023 12:05:20 +0900
Gildong Hong <roaming2man@gmail.com> wrote:
> > > - TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
> > > + TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
>
> "vns" sounds nice.
> But some people may hard to understand the meaning.
> "ns" is a global standard time unit where "vns" is not.
> So I still prefer to remove the unit.
Really? You have "runtime" (which most people understand) and labeled
"ns", but then you have "vruntime" which some people may find hard to
understand the meaning of. If they do understand the meaning of
"vruntime" then they should have the means to understand "vns".
Otherwise, no label is meaningless too!
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value
2023-03-19 18:07 ` Steven Rostedt
@ 2023-03-20 11:41 ` Gildong Hong
2023-03-20 18:02 ` Steven Rostedt
2023-03-20 11:41 ` Peter Zijlstra
1 sibling, 1 reply; 7+ messages in thread
From: Gildong Hong @ 2023-03-20 11:41 UTC (permalink / raw)
To: Steven Rostedt; +Cc: mhiramat, delyank, peterz, linux-trace-kernel
On Sun, Mar 19, 2023 at 02:07:38PM -0400, Steven Rostedt wrote:
> On Sun, 19 Mar 2023 12:05:20 +0900
> Gildong Hong <roaming2man@gmail.com> wrote:
>
> > > > - TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
> > > > + TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
>
> >
> > "vns" sounds nice.
> > But some people may hard to understand the meaning.
> > "ns" is a global standard time unit where "vns" is not.
> > So I still prefer to remove the unit.
>
> Really? You have "runtime" (which most people understand) and labeled
> "ns", but then you have "vruntime" which some people may find hard to
> understand the meaning of. If they do understand the meaning of
> "vruntime" then they should have the means to understand "vns".
>
> Otherwise, no label is meaningless too!
>
> -- Steve
I agree with your opinion.
People can understand "vns" if they understand "vruntime".
Followings are the modified patch.
I add your name on "Suggested-by"
I or you could remove the line if you mind it.
Thanks,
Gildong
------------
From 8a8d1f08a2f217151f26f04795d6c1483eb1c48f Mon Sep 17 00:00:00 2001
From: Gildong Hong <roaming2man@gmail.com>
Date: Thu, 16 Mar 2023 20:05:48 +0900
Subject: [PATCH] trace/events/sched: Change unit on printing vruntime value
vruntime is not actual time so change unit on printing
from "ns" to "vns" which denotes "virtual nanosecond"
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Gildong Hong <roaming2man@gmail.com>
---
include/trace/events/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index fbb99a61f714..993986c6c3f6 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -511,7 +511,7 @@ DECLARE_EVENT_CLASS(sched_stat_runtime,
__entry->vruntime = vruntime;
),
- TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
+ TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [vns]",
__entry->comm, __entry->pid,
(unsigned long long)__entry->runtime,
(unsigned long long)__entry->vruntime)
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value
2023-03-20 11:41 ` Gildong Hong
@ 2023-03-20 18:02 ` Steven Rostedt
0 siblings, 0 replies; 7+ messages in thread
From: Steven Rostedt @ 2023-03-20 18:02 UTC (permalink / raw)
To: Gildong Hong; +Cc: mhiramat, delyank, peterz, linux-trace-kernel
On Mon, 20 Mar 2023 20:41:39 +0900
Gildong Hong <roaming2man@gmail.com> wrote:
> I agree with your opinion.
> People can understand "vns" if they understand "vruntime".
> Followings are the modified patch.
> I add your name on "Suggested-by"
> I or you could remove the line if you mind it.
I'm good.
Thanks,
-- Steve
>
> Thanks,
> Gildong
>
> ------------
> >From 8a8d1f08a2f217151f26f04795d6c1483eb1c48f Mon Sep 17 00:00:00 2001
> From: Gildong Hong <roaming2man@gmail.com>
> Date: Thu, 16 Mar 2023 20:05:48 +0900
> Subject: [PATCH] trace/events/sched: Change unit on printing vruntime value
>
> vruntime is not actual time so change unit on printing
> from "ns" to "vns" which denotes "virtual nanosecond"
>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Gildong Hong <roaming2man@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value
2023-03-19 18:07 ` Steven Rostedt
2023-03-20 11:41 ` Gildong Hong
@ 2023-03-20 11:41 ` Peter Zijlstra
1 sibling, 0 replies; 7+ messages in thread
From: Peter Zijlstra @ 2023-03-20 11:41 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Gildong Hong, mhiramat, delyank, linux-trace-kernel
On Sun, Mar 19, 2023 at 02:07:38PM -0400, Steven Rostedt wrote:
> On Sun, 19 Mar 2023 12:05:20 +0900
> Gildong Hong <roaming2man@gmail.com> wrote:
>
> > > > - TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
> > > > + TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
>
> >
> > "vns" sounds nice.
> > But some people may hard to understand the meaning.
> > "ns" is a global standard time unit where "vns" is not.
> > So I still prefer to remove the unit.
>
> Really? You have "runtime" (which most people understand) and labeled
> "ns", but then you have "vruntime" which some people may find hard to
> understand the meaning of. If they do understand the meaning of
> "vruntime" then they should have the means to understand "vns".
>
> Otherwise, no label is meaningless too!
I'm with Steve, if you're down to consuming these here numbers, you'd
better know wth you're doing.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-20 18:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-16 11:56 [PATCH] trace/events/sched: Remove unit on printing vruntime value Gildong Hong
2023-03-16 14:11 ` Steven Rostedt
2023-03-19 3:05 ` Gildong Hong
2023-03-19 18:07 ` Steven Rostedt
2023-03-20 11:41 ` Gildong Hong
2023-03-20 18:02 ` Steven Rostedt
2023-03-20 11:41 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).