From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Gildong Hong <roaming2man@gmail.com>,
mhiramat@kernel.org, delyank@fb.com,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value
Date: Mon, 20 Mar 2023 12:41:55 +0100 [thread overview]
Message-ID: <20230320114155.GJ2194297@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230319140738.57170fab@rorschach.local.home>
On Sun, Mar 19, 2023 at 02:07:38PM -0400, Steven Rostedt wrote:
> On Sun, 19 Mar 2023 12:05:20 +0900
> Gildong Hong <roaming2man@gmail.com> wrote:
>
> > > > - TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
> > > > + TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",
>
> >
> > "vns" sounds nice.
> > But some people may hard to understand the meaning.
> > "ns" is a global standard time unit where "vns" is not.
> > So I still prefer to remove the unit.
>
> Really? You have "runtime" (which most people understand) and labeled
> "ns", but then you have "vruntime" which some people may find hard to
> understand the meaning of. If they do understand the meaning of
> "vruntime" then they should have the means to understand "vns".
>
> Otherwise, no label is meaningless too!
I'm with Steve, if you're down to consuming these here numbers, you'd
better know wth you're doing.
prev parent reply other threads:[~2023-03-20 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 11:56 [PATCH] trace/events/sched: Remove unit on printing vruntime value Gildong Hong
2023-03-16 14:11 ` Steven Rostedt
2023-03-19 3:05 ` Gildong Hong
2023-03-19 18:07 ` Steven Rostedt
2023-03-20 11:41 ` Gildong Hong
2023-03-20 18:02 ` Steven Rostedt
2023-03-20 11:41 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320114155.GJ2194297@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=delyank@fb.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=roaming2man@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).