From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36625C761A6 for ; Tue, 21 Mar 2023 14:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbjCUOEi (ORCPT ); Tue, 21 Mar 2023 10:04:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbjCUOEi (ORCPT ); Tue, 21 Mar 2023 10:04:38 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76B1E20A00 for ; Tue, 21 Mar 2023 07:04:36 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id o40-20020a05600c512800b003eddedc47aeso4071039wms.3 for ; Tue, 21 Mar 2023 07:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679407475; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Eyc9M815DDWPE+a5iQ5MddjThl1AbQtLO2yVDEfZLUY=; b=GXjeLkvKjytTCw5uvgmOTPE72dJ3RoJKaN4OhBTYpmZH634OeIJ9U9cmpyukPU8pf2 p8z8E2TpYumBVVrBbBaHDwvUeaUd79xpcPLLvl3WT2i2BfepOcb+8fAFNrfBc65/QV4i bTRYMbd1T8XGBarkJrOeUnNdwTh26TkUUqe1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679407475; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Eyc9M815DDWPE+a5iQ5MddjThl1AbQtLO2yVDEfZLUY=; b=ALuhNsIza3PO4a9wPfFRPRbF65MesrTougUaB6gKlsEs26A8vQ42eoCQ+drNxawZ/a 48VXuR3YZC8RGBZ4IylvH48veoYyFvSebLQGBaOnXLyy3BZy0UfAvlUd7DPH7PzI8ryP lL1xWUCzGKBtmOzynyoLi5WjbEpP42ZfYwJQ2RKoPPw/MPFzNhbB52cw8YqxPcxgDzjt mGh65Q8bPnPHPHMJU6WG3IDBDJEb/Uru71+PLgN7aKHWt8prQuXrfXf6E35zxmF4UZg0 rZEdhSD2LkS0UFNrkeHOn5jyJ6Db8OxyOPXhSVJda50KLvnMxw9d5QcvXm/pE0ZZqXT9 tv9A== X-Gm-Message-State: AO0yUKXOGl1ZLrlWMg1j5tO9mvNWLxOwruU4+OiL+TwZDDp3wgPgrgIy /AiaYaKxCqIeQLwbNEgNjdb8kQ== X-Google-Smtp-Source: AK7set+y3+a5NcLXFa6wVgIOm4MXUQFs8Vfjy2+3xjt1w+J7OQdgRVkS4bb9JL2mGu6q6T1ODgPuuw== X-Received: by 2002:a1c:f210:0:b0:3eb:39e0:3530 with SMTP id s16-20020a1cf210000000b003eb39e03530mr2480006wmc.41.1679407474866; Tue, 21 Mar 2023 07:04:34 -0700 (PDT) Received: from revest.zrh.corp.google.com ([2a00:79e0:9d:6:4b8c:8b16:90d:8d9a]) by smtp.gmail.com with ESMTPSA id f12-20020a1cc90c000000b003e20cf0408esm13620896wmb.40.2023.03.21.07.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:04:34 -0700 (PDT) From: Florent Revest To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: rostedt@goodmis.org, mhiramat@kernel.org, mark.rutland@arm.com, ast@kernel.org, daniel@iogearbox.net, kpsingh@kernel.org, revest@chromium.org, jolsa@kernel.org Subject: [PATCH v2 0/7] Refactor ftrace direct call APIs Date: Tue, 21 Mar 2023 15:04:17 +0100 Message-Id: <20230321140424.345218-1-revest@chromium.org> X-Mailer: git-send-email 2.40.0.rc2.332.ga46443480c-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org Differences since v1 [1]: - Use a READ_ONCE() to read the direct call address in call_direct_funcs - Added an Acked-by from Mark This series refactors ftrace direct call APIs in preparation for arm64 support. It is roughly a subset of [2] rebased on v6.3-rc2 and meant to be taken by Steven's tree before all the arm64 specific bits. The first patch was suggested by Steven in a review of [1], it makes it more obvious to the caller that filters probably need to be freed when unregistering a direct call. The next three patches consolidate the two existing ftrace APIs for registering direct calls. They are only split to make the reviewer's life easier. Currently, there is both a _ftrace_direct and _ftrace_direct_multi API. Apart from samples and selftests, there are no users of the _ftrace_direct API left in-tree so this deletes it and renames the _ftrace_direct_multi API to _ftrace_direct for simplicity. The main benefit of this refactoring is that, with the API that's left, an ftrace_ops backing a direct call will only ever point to one direct call. We can therefore store the direct called trampoline address in the ops (patch 5) and, in the future arm64 series, look it up from the ftrace trampoline. (in the meantime, it makes call_direct_funcs a bit simpler too) Ftrace direct calls technically don't need DYNAMIC_FTRACE_WITH_REGS so this extends its support to DYNAMIC_FTRACE_WITH_ARGS (patch 6). arm64 won't support DYNAMIC_FTRACE_WITH_REGS. Finally, it fixes the ABI of the stub direct call trampoline used in ftrace selftests. This has been tested on x86_64 with: 1- CONFIG_FTRACE_SELFTEST 2- samples/ftrace/*.ko 1: https://lore.kernel.org/all/20230316173811.1223508-1-revest@chromium.org/T/#t 2: https://lore.kernel.org/all/20230207182135.2671106-1-revest@chromium.org/T/#t Florent Revest (6): ftrace: Let unregister_ftrace_direct_multi() call ftrace_free_filter() ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi ftrace: Remove the legacy _ftrace_direct API ftrace: Rename _ftrace_direct_multi APIs to _ftrace_direct APIs ftrace: Store direct called addresses in their ops ftrace: Make DIRECT_CALLS work WITH_ARGS and !WITH_REGS Mark Rutland (1): ftrace: selftest: remove broken trace_direct_tramp arch/s390/kernel/mcount.S | 5 + arch/x86/kernel/ftrace_32.S | 5 + arch/x86/kernel/ftrace_64.S | 4 + include/linux/ftrace.h | 61 +-- kernel/bpf/trampoline.c | 12 +- kernel/trace/Kconfig | 2 +- kernel/trace/ftrace.c | 438 ++------------------ kernel/trace/trace_selftest.c | 19 +- samples/Kconfig | 2 +- samples/ftrace/ftrace-direct-modify.c | 10 +- samples/ftrace/ftrace-direct-multi-modify.c | 9 +- samples/ftrace/ftrace-direct-multi.c | 5 +- samples/ftrace/ftrace-direct-too.c | 10 +- samples/ftrace/ftrace-direct.c | 10 +- 14 files changed, 101 insertions(+), 491 deletions(-) -- 2.40.0.rc2.332.ga46443480c-goog