* [PATCH v2 05/13] rcu/trace: use strscpy() to instead of strncpy()
[not found] <20230325173316.3118674-1-joel@joelfernandes.org>
@ 2023-03-25 17:33 ` Joel Fernandes (Google)
2023-03-25 17:33 ` [PATCH v2 07/13] rcu: Fix missing TICK_DEP_MASK_RCU_EXP dependency check Joel Fernandes (Google)
1 sibling, 0 replies; 2+ messages in thread
From: Joel Fernandes (Google) @ 2023-03-25 17:33 UTC (permalink / raw)
To: linux-kernel, Steven Rostedt, Masami Hiramatsu
Cc: Xu Panda, Yang Yang, Paul E . McKenney, Joel Fernandes,
linux-trace-kernel
From: Xu Panda <xu.panda@zte.com.cn>
This commit saves a line of code by switching from strncpy() to strscpy()
by permitting the later NUL assignment to be removed. While in the area,
save another line by taking advantage of 100 characters.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
include/trace/events/rcu.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h
index 90b2fb0292cb..c19ac1fa8a60 100644
--- a/include/trace/events/rcu.h
+++ b/include/trace/events/rcu.h
@@ -776,9 +776,7 @@ TRACE_EVENT_RCU(rcu_torture_read,
),
TP_fast_assign(
- strncpy(__entry->rcutorturename, rcutorturename,
- RCUTORTURENAME_LEN);
- __entry->rcutorturename[RCUTORTURENAME_LEN - 1] = 0;
+ strscpy(__entry->rcutorturename, rcutorturename, RCUTORTURENAME_LEN);
__entry->rhp = rhp;
__entry->secs = secs;
__entry->c_old = c_old;
--
2.40.0.348.gf938b09366-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH v2 07/13] rcu: Fix missing TICK_DEP_MASK_RCU_EXP dependency check
[not found] <20230325173316.3118674-1-joel@joelfernandes.org>
2023-03-25 17:33 ` [PATCH v2 05/13] rcu/trace: use strscpy() to instead of strncpy() Joel Fernandes (Google)
@ 2023-03-25 17:33 ` Joel Fernandes (Google)
1 sibling, 0 replies; 2+ messages in thread
From: Joel Fernandes (Google) @ 2023-03-25 17:33 UTC (permalink / raw)
To: linux-kernel, Steven Rostedt, Masami Hiramatsu,
Frederic Weisbecker, Thomas Gleixner, Ingo Molnar,
Paul E. McKenney
Cc: Zqiang, Anna-Maria Behnsen, Frederic Weisbecker, Joel Fernandes,
linux-trace-kernel
From: Zqiang <qiang1.zhang@intel.com>
This commit adds checks for the TICK_DEP_MASK_RCU_EXP bit, thus enabling
RCU expedited grace periods to actually force-enable scheduling-clock
interrupts on holdout CPUs.
Fixes: df1e849ae455 ("rcu: Enable tick for nohz_full CPUs slow to provide expedited QS")
Signed-off-by: Zqiang <qiang1.zhang@intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
include/trace/events/timer.h | 3 ++-
kernel/time/tick-sched.c | 5 +++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
index 2e713a7d9aa3..3e8619c72f77 100644
--- a/include/trace/events/timer.h
+++ b/include/trace/events/timer.h
@@ -371,7 +371,8 @@ TRACE_EVENT(itimer_expire,
tick_dep_name(PERF_EVENTS) \
tick_dep_name(SCHED) \
tick_dep_name(CLOCK_UNSTABLE) \
- tick_dep_name_end(RCU)
+ tick_dep_name(RCU) \
+ tick_dep_name_end(RCU_EXP)
#undef tick_dep_name
#undef tick_dep_mask_name
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 68d81a4283c8..a46506f7ec6d 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -281,6 +281,11 @@ static bool check_tick_dependency(atomic_t *dep)
return true;
}
+ if (val & TICK_DEP_MASK_RCU_EXP) {
+ trace_tick_stop(0, TICK_DEP_MASK_RCU_EXP);
+ return true;
+ }
+
return false;
}
--
2.40.0.348.gf938b09366-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread