From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v2 1/2] ring-buffer: Introducing ring-buffer mapping functions
Date: Wed, 29 Mar 2023 08:07:58 -0400 [thread overview]
Message-ID: <20230329080758.0e730796@rorschach.local.home> (raw)
In-Reply-To: <20230329070353.1e1b443b@gandalf.local.home>
On Wed, 29 Mar 2023 07:03:53 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> struct ring_buffer_meta_page_header {
> #if __BITS_PER_LONG == 64
> __u64 entries;
> __u64 overrun;
> #else
> __u32 entries;
> __u32 overrun;
> #endif
> __u32 pages_touched;
> __u32 meta_page_size;
> __u32 reader_page; /* page ID for the reader page */
> __u32 nr_data_pages; /* doesn't take into account the reader_page */
> };
>
> BTW, shouldn't the nr_data_pages take into account the reader page? As it
> is part of the array we traverse isn't it?
Ah, I guess nr_data_pages is the length of the index mapping, not the
array of pages mapped?
-- Steve
next prev parent reply other threads:[~2023-03-29 12:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 10:22 [PATCH v2 0/2] Introducing trace buffer mapping by user-space Vincent Donnefort
2023-03-22 10:22 ` [PATCH v2 1/2] ring-buffer: Introducing ring-buffer mapping functions Vincent Donnefort
2023-03-29 2:44 ` Steven Rostedt
2023-03-29 9:19 ` Vincent Donnefort
2023-03-29 11:03 ` Steven Rostedt
2023-03-29 12:07 ` Steven Rostedt [this message]
2023-03-29 12:27 ` Vincent Donnefort
2023-03-29 12:23 ` Vincent Donnefort
2023-03-29 12:47 ` Steven Rostedt
2023-03-29 13:10 ` Vincent Donnefort
2023-03-29 13:14 ` Steven Rostedt
2023-03-30 14:48 ` Vincent Donnefort
2023-03-29 12:51 ` Steven Rostedt
2023-03-29 13:01 ` Vincent Donnefort
2023-03-29 13:11 ` Steven Rostedt
2023-03-29 13:31 ` Vincent Donnefort
2023-03-29 13:36 ` Steven Rostedt
2023-03-29 13:55 ` Vincent Donnefort
2023-03-29 15:08 ` Vincent Donnefort
2023-03-29 15:32 ` Steven Rostedt
2023-03-30 10:30 ` Vincent Donnefort
2023-03-30 15:21 ` Steven Rostedt
2023-03-22 10:22 ` [PATCH v2 2/2] tracing: Allow user-space mapping of the ring-buffer Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329080758.0e730796@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).