From: Steven Rostedt <rostedt@goodmis.org>
To: "Tze-nan Wu (吳澤南)" <Tze-nan.Wu@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Cheng-Jui Wang (王正睿)" <Cheng-Jui.Wang@mediatek.com>,
"paulmck@kernel.org" <paulmck@kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Bobule Chang (張弘義)" <bobule.chang@mediatek.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"npiggin@gmail.com" <npiggin@gmail.com>
Subject: Re: [PATCH v3] ring-buffer: Prevent inconsistent operation on cpu_buffer->resize_disabled
Date: Tue, 11 Apr 2023 22:32:06 -0400 [thread overview]
Message-ID: <20230411223206.0bc5794e@gandalf.local.home> (raw)
In-Reply-To: <ef0ebc2f0f934ff5c35719f1960d24a5838ff770.camel@mediatek.com>
On Wed, 12 Apr 2023 02:27:53 +0000
Tze-nan Wu (吳澤南) <Tze-nan.Wu@mediatek.com> wrote:
> > > @@ -5368,7 +5372,7 @@ void ring_buffer_reset_online_cpus(struct
> > > trace_buffer *buffer)
> > > /* Make sure all commits have finished */
> > > synchronize_rcu();
> > >
> > > - for_each_online_buffer_cpu(buffer, cpu) {
> > > + for_each_cpu_and(cpu, buffer->cpumask, &reset_online_cpumask)
>
> Maybe we should use for_each_buffer_cpu(buffer, cpu) here?
> since a CPU may also came offline during synchronize_rcu().
Yeah, I guess that works too (not looking at the code at the moment though).
-- Steve
>
> > > {
> > > cpu_buffer = buffer->buffers[cpu];
> >
next prev parent reply other threads:[~2023-04-12 2:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 5:22 [PATCH] ring-buffer: Prevent inconsistent operation on cpu_buffer->resize_disabled Tze-nan Wu
2023-04-08 8:35 ` kernel test robot
2023-04-08 12:20 ` kernel test robot
2023-04-09 2:46 ` [PATCH v2] " Tze-nan Wu
2023-04-09 12:30 ` Bagas Sanjaya
2023-04-10 1:35 ` Tze-nan Wu (吳澤南)
2023-04-10 7:35 ` [PATCH v3] " Tze-nan Wu
2023-04-11 16:44 ` Steven Rostedt
2023-04-11 16:48 ` Steven Rostedt
2023-04-12 2:27 ` Tze-nan Wu (吳澤南)
2023-04-12 2:32 ` Steven Rostedt [this message]
2023-04-14 1:16 ` Tze-nan Wu (吳澤南)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411223206.0bc5794e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Cheng-Jui.Wang@mediatek.com \
--cc=Tze-nan.Wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bobule.chang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).