From: Steven Rostedt <rostedt@goodmis.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
dcook@linux.microsoft.com, alanau@linux.microsoft.com,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] tracing/user_events: Prevent same address and bit per process
Date: Mon, 24 Apr 2023 21:41:18 -0400 [thread overview]
Message-ID: <20230424214118.06b7ee07@rorschach.local.home> (raw)
In-Reply-To: <20230411211709.15018-4-beaub@linux.microsoft.com>
On Tue, 11 Apr 2023 14:17:09 -0700
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> +static bool user_event_enabler_exists(struct user_event_mm *mm,
> + unsigned long uaddr, unsigned char bit)
> +{
> + struct user_event_enabler *enabler;
> + struct user_event_enabler *next;
> +
> + list_for_each_entry_safe(enabler, next, &mm->enablers, link)
> + if (enabler->addr == uaddr &&
> + (enabler->values & ENABLE_VAL_BIT_MASK) == bit)
> + return true;
> +
Please add brackets around complex calls like the above. The no bracket
rule is not if you can get away without using it, but if there's only a
single line.
list_for_each_entry_safe(enabler, next, &mm->enablers, link) {
if (enabler->addr == uaddr &&
(enabler->values & ENABLE_VAL_BIT_MASK) == bit)
return true;
}
-- Steve
> + return false;
> +}
> +
prev parent reply other threads:[~2023-04-25 1:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 21:17 [PATCH 0/3] tracing/user_events: Fixes and improvements for 6.4 Beau Belgrave
2023-04-11 21:17 ` [PATCH 1/3] tracing/user_events: Ensure write index cannot be negative Beau Belgrave
2023-04-25 14:43 ` Masami Hiramatsu
2023-04-11 21:17 ` [PATCH 2/3] tracing/user_events: Ensure bit is cleared on unregister Beau Belgrave
2023-04-25 1:39 ` Steven Rostedt
2023-04-25 17:06 ` Beau Belgrave
2023-04-25 17:56 ` Steven Rostedt
2023-04-11 21:17 ` [PATCH 3/3] tracing/user_events: Prevent same address and bit per process Beau Belgrave
2023-04-25 1:41 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424214118.06b7ee07@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=alanau@linux.microsoft.com \
--cc=beaub@linux.microsoft.com \
--cc=dcook@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).