From: Steven Rostedt <rostedt@goodmis.org>
To: sunying@nj.iscas.ac.cn
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v1] trace: add the necessary dependencies of configuration options
Date: Tue, 25 Apr 2023 15:02:36 -0400 [thread overview]
Message-ID: <20230425150236.005e2e8b@gandalf.local.home> (raw)
In-Reply-To: <20230414082756.24119-1-sunying@nj.iscas.ac.cn>
On Fri, 14 Apr 2023 16:27:56 +0800
sunying@nj.iscas.ac.cn wrote:
> From: Ying Sun <sunying@nj.iscas.ac.cn>
>
> HAVE_NOP_MCOUNT is used only if the condition
> "ifdef CONFIG_FTRACE_MCOUNT_USE_CC" is met in the Makefile,
> adding a dependency constraint on this configuration option
> to prevent it from being set ‘y' but not taking effect.
>
> Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
> Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 8cf97fa4a4b3..c640f405cc91 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -77,6 +77,7 @@ config HAVE_FENTRY
>
> config HAVE_NOP_MCOUNT
> bool
> + depends on FTRACE_MCOUNT_USE_CC
As I replied to the other email. The HAVE_* configs are only for
architectures to say if they support something or not. There's no need to
add dependencies here.
-- Steve
> help
> Arch supports the gcc options -pg with -mrecord-mcount and -nop-mcount
>
prev parent reply other threads:[~2023-04-25 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 8:27 [PATCH v1] trace: add the necessary dependencies of configuration options sunying
2023-04-25 19:02 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425150236.005e2e8b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=sunying@nj.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).