From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC0BFC77B61 for ; Tue, 25 Apr 2023 19:02:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235150AbjDYTCp convert rfc822-to-8bit (ORCPT ); Tue, 25 Apr 2023 15:02:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235138AbjDYTCn (ORCPT ); Tue, 25 Apr 2023 15:02:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B1AF5FDD; Tue, 25 Apr 2023 12:02:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51C2963113; Tue, 25 Apr 2023 19:02:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34811C433D2; Tue, 25 Apr 2023 19:02:39 +0000 (UTC) Date: Tue, 25 Apr 2023 15:02:36 -0400 From: Steven Rostedt To: sunying@nj.iscas.ac.cn Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v1] trace: add the necessary dependencies of configuration options Message-ID: <20230425150236.005e2e8b@gandalf.local.home> In-Reply-To: <20230414082756.24119-1-sunying@nj.iscas.ac.cn> References: <20230414082756.24119-1-sunying@nj.iscas.ac.cn> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Fri, 14 Apr 2023 16:27:56 +0800 sunying@nj.iscas.ac.cn wrote: > From: Ying Sun > > HAVE_NOP_MCOUNT is used only if the condition > "ifdef CONFIG_FTRACE_MCOUNT_USE_CC" is met in the Makefile, > adding a dependency constraint on this configuration option > to prevent it from being set ‘y' but not taking effect. > > Suggested-by: Yanjie Ren > Signed-off-by: Ying Sun > --- > kernel/trace/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 8cf97fa4a4b3..c640f405cc91 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -77,6 +77,7 @@ config HAVE_FENTRY > > config HAVE_NOP_MCOUNT > bool > + depends on FTRACE_MCOUNT_USE_CC As I replied to the other email. The HAVE_* configs are only for architectures to say if they support something or not. There's no need to add dependencies here. -- Steve > help > Arch supports the gcc options -pg with -mrecord-mcount and -nop-mcount >