* [PATCH v1] trace: add the necessary dependencies of configuration options
@ 2023-04-14 8:27 sunying
2023-04-25 19:02 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: sunying @ 2023-04-14 8:27 UTC (permalink / raw)
To: rostedt, mhiramat, linux-kernel; +Cc: linux-trace-kernel, Ying Sun
From: Ying Sun <sunying@nj.iscas.ac.cn>
HAVE_NOP_MCOUNT is used only if the condition
"ifdef CONFIG_FTRACE_MCOUNT_USE_CC" is met in the Makefile,
adding a dependency constraint on this configuration option
to prevent it from being set ‘y' but not taking effect.
Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
---
kernel/trace/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 8cf97fa4a4b3..c640f405cc91 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -77,6 +77,7 @@ config HAVE_FENTRY
config HAVE_NOP_MCOUNT
bool
+ depends on FTRACE_MCOUNT_USE_CC
help
Arch supports the gcc options -pg with -mrecord-mcount and -nop-mcount
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] trace: add the necessary dependencies of configuration options
2023-04-14 8:27 [PATCH v1] trace: add the necessary dependencies of configuration options sunying
@ 2023-04-25 19:02 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2023-04-25 19:02 UTC (permalink / raw)
To: sunying; +Cc: mhiramat, linux-kernel, linux-trace-kernel
On Fri, 14 Apr 2023 16:27:56 +0800
sunying@nj.iscas.ac.cn wrote:
> From: Ying Sun <sunying@nj.iscas.ac.cn>
>
> HAVE_NOP_MCOUNT is used only if the condition
> "ifdef CONFIG_FTRACE_MCOUNT_USE_CC" is met in the Makefile,
> adding a dependency constraint on this configuration option
> to prevent it from being set ‘y' but not taking effect.
>
> Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
> Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 8cf97fa4a4b3..c640f405cc91 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -77,6 +77,7 @@ config HAVE_FENTRY
>
> config HAVE_NOP_MCOUNT
> bool
> + depends on FTRACE_MCOUNT_USE_CC
As I replied to the other email. The HAVE_* configs are only for
architectures to say if they support something or not. There's no need to
add dependencies here.
-- Steve
> help
> Arch supports the gcc options -pg with -mrecord-mcount and -nop-mcount
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-25 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-14 8:27 [PATCH v1] trace: add the necessary dependencies of configuration options sunying
2023-04-25 19:02 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).