From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
Florent Revest <revest@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf@vger.kernel.org
Subject: Re: [PATCH v9.1 01/11] fprobe: Pass return address to the handlers
Date: Tue, 9 May 2023 23:51:21 +0900 [thread overview]
Message-ID: <20230509235121.28974ab2b5341eade5491a35@kernel.org> (raw)
In-Reply-To: <20230505112134.34669200@gandalf.local.home>
On Fri, 5 May 2023 11:21:34 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 2 May 2023 11:17:28 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >
> > Pass return address as 'ret_ip' to the fprobe entry and return handlers.
>
> The change log tells us "what" but not "why".
Indeed, and thanks, I almost forgot the reason why I introduced it :(
This is actually for fprobe_exit_handler() to pass the return address to
user handler so that the fprobe-events can show the return address correctly.
When I implemented the fprobe-events, I found this was required but splitted
from the main fprobe event patch but forgot to update the description.
Let me update it.
Thank you!
>
> -- Steve
>
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > ---
> >
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-05-09 14:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 2:17 [PATCH v9.1 00/11] tracing: Add fprobe/tracepoint events Masami Hiramatsu (Google)
2023-05-02 2:17 ` [PATCH v9.1 01/11] fprobe: Pass return address to the handlers Masami Hiramatsu (Google)
2023-05-05 15:21 ` Steven Rostedt
2023-05-09 14:51 ` Masami Hiramatsu [this message]
2023-05-02 2:17 ` [PATCH v9.1 02/11] tracing/probes: Add fprobe events for tracing function entry and exit Masami Hiramatsu (Google)
2023-05-05 16:12 ` Steven Rostedt
2023-05-09 15:08 ` Masami Hiramatsu
2023-05-02 2:17 ` [PATCH v9.1 03/11] selftests/ftrace: Add fprobe related testcases Masami Hiramatsu (Google)
2023-05-02 2:17 ` [PATCH v9.1 04/11] tracing/probes: Add tracepoint support on fprobe_events Masami Hiramatsu (Google)
2023-05-02 2:18 ` [PATCH v9.1 05/11] tracing/probes: Move event parameter fetching code to common parser Masami Hiramatsu (Google)
2023-05-05 21:40 ` Steven Rostedt
2023-05-14 4:11 ` Masami Hiramatsu
2023-05-02 2:18 ` [PATCH v9.1 06/11] tracing/probes: Support function parameters if BTF is available Masami Hiramatsu (Google)
2023-05-02 2:18 ` [PATCH v9.1 07/11] tracing/probes: Add $$args meta argument for all function args Masami Hiramatsu (Google)
2023-05-05 21:48 ` Steven Rostedt
2023-05-14 3:02 ` Masami Hiramatsu
2023-05-02 2:18 ` [PATCH v9.1 08/11] tracing/probes: Add BTF retval type support Masami Hiramatsu (Google)
2023-05-02 2:18 ` [PATCH v9.1 09/11] selftests/ftrace: Add tracepoint probe test case Masami Hiramatsu (Google)
2023-05-02 2:18 ` [PATCH v9.1 10/11] selftests/ftrace: Add BTF arguments test cases Masami Hiramatsu (Google)
2023-05-02 2:18 ` [PATCH v9.1 11/11] Documentation: tracing/probes: Add fprobe event tracing document Masami Hiramatsu (Google)
2023-05-05 15:20 ` Steven Rostedt
2023-05-09 14:58 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509235121.28974ab2b5341eade5491a35@kernel.org \
--to=mhiramat@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).