From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9563EC77B75 for ; Thu, 18 May 2023 00:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229468AbjERAOc (ORCPT ); Wed, 17 May 2023 20:14:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjERAOb (ORCPT ); Wed, 17 May 2023 20:14:31 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 494D0E40; Wed, 17 May 2023 17:14:30 -0700 (PDT) Received: from W11-BEAU-MD.localdomain (unknown [76.135.27.212]) by linux.microsoft.com (Postfix) with ESMTPSA id 5995920F32BA; Wed, 17 May 2023 17:14:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5995920F32BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1684368869; bh=VVEoDio0arKGJFJsHofzfO3jj1x9hJ9mzHCNy2yQvWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jtF2J0ma4ETtlJcLPLfrQQfHtw/SSMOAS7sR7k/hbQMqv5qDIHWANdlW2fw+3BXVH s5tve9kbRFKZV6QSlY/WpHVtLI/5Kcl6IwzwsmYBVyu4Ntl8ALEc2sw0H8gA0b0EfX QNFNsjWBO8HWt4WQo7sT49CtShgqJaFFOwDbwLjE= Date: Wed, 17 May 2023 17:14:22 -0700 From: Beau Belgrave To: Steven Rostedt Cc: Linus Torvalds , Alexei Starovoitov , Masami Hiramatsu , LKML , linux-trace-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , bpf , David Vernet , dthaler@microsoft.com, brauner@kernel.org, hch@infradead.org Subject: Re: [PATCH] tracing/user_events: Run BPF program if attached Message-ID: <20230518001422.GA254@W11-BEAU-MD.localdomain> References: <20230517172243.GA152@W11-BEAU-MD.localdomain> <20230517190750.GA366@W11-BEAU-MD.localdomain> <20230517230054.GA195@W11-BEAU-MD.localdomain> <20230517192528.043adc7a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230517192528.043adc7a@gandalf.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Wed, May 17, 2023 at 07:25:28PM -0400, Steven Rostedt wrote: > On Wed, 17 May 2023 16:14:43 -0700 > Linus Torvalds wrote: > > > On Wed, May 17, 2023 at 4:01 PM Beau Belgrave wrote: > > > > > > Do you mind giving me your Signed-off-by for these? > > > > Assuming you have some test-cases that you've run them through, then yes: > > Beau, > > Can you update the tools/testing/selftests/user_events/ to make sure that > it triggers the lockdep splat without these updates (assuming that it does > trigger without these patches). Then add these patches to make sure the > splat goes away. This will confirm that the patches do what is expected of > them. > Yes, I have run these through selftests with CONFIG_DEBUG_ATOMIC_SLEEP=y. I can confirm without the patches it splats with that setting. When these have been applied, the splat is gone. > I usually run the selftests for tracing and for your user events with > lockdep and prove locking enabled. But it may have triggered on something > else disabling it when I ran my tests, in which case I sometimes disable > that and forget to re-enable it. > Do you run with CONFIG_DEBUG_ATOMIC_SLEEP? It will not splat with just CONFIG_PROVE_LOCKING and CONFIG_PROVE_RCU, which bit me here. I'm now running all three now that I know better. > -- Steve Thanks, -Beau