linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Daejun Park <daejun7.park@samsung.com>,
	"chao@kernel.org" <chao@kernel.org>,
	"mhiramat@kernel.org" <mhiramat@kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net" 
	<linux-f2fs-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-trace-kernel@vger.kernel.org" 
	<linux-trace-kernel@vger.kernel.org>,
	Seokhwan Kim <sukka.kim@samsung.com>,
	Yonggil Song <yonggil.song@samsung.com>,
	beomsu kim <beomsu7.kim@samsung.com>
Subject: Re: [PATCH v6] f2fs: add async reset zone command support
Date: Tue, 23 May 2023 10:43:47 -0400	[thread overview]
Message-ID: <20230523104347.61149ecd@rorschach.local.home> (raw)
In-Reply-To: <ZFqWr3sSYMsHtHAC@google.com>

On Tue, 9 May 2023 11:53:35 -0700
Jaegeuk Kim <jaegeuk@kernel.org> wrote:

> On 05/08, Daejun Park wrote:
> > v5 -> v6
> > Added trace_f2fs_iostat support for zone reset command.
> > 
> > v4 -> v5
> > Added f2fs iostat for zone reset command.
> > 
> > v3 -> v4
> > Fixed build error caused by unused function.
> > 
> > v2 -> v3
> > Modified arguments to be correct for ftrace parameter.
> > Changed __submit_zone_reset_cmd to void return.
> > Refactored the f2fs_wait_discard_bio function.
> > Fixed code that was previously incorrectly merged.
> > 
> > v1 -> v2
> > Changed to apply the optional async reset write pointer by default.  
> 
> Don't add the history in the patch description.

Well, you can (and should) ...

> 
> > 
> > This patch enables submit reset zone command asynchornously. It helps
> > decrease average latency of write IOs in high utilization scenario by
> > faster checkpointing.
> > 
> > Signed-off-by: Daejun Park <daejun7.park@samsung.com>
> > ---

But it must go below the three dashes above. That will keep 'git am'
from adding it to the change log.

-- Steve


> >  fs/f2fs/f2fs.h              |  1 +
> >  fs/f2fs/iostat.c            |  1 +
> >  fs/f2fs/segment.c           | 84 +++++++++++++++++++++++++++++++++++--
> >  include/trace/events/f2fs.h | 24 +++++++++--
> >  4 files changed, 104 insertions(+), 6 deletions(-)
> > 
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index d211ee89c158..51b68a629814 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -1175,6 +1175,7 @@ enum iostat_type {
> >  	/* other */
> >  	FS_DISCARD_IO,			/* discard */
> >  	FS_FLUSH_IO,			/* flush */
> > +	FS_ZONE_RESET_IO,		/* zone reset */
> >  	NR_IO_TYPE,
> >  };
> >  

  reply	other threads:[~2023-05-23 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230508081042epcms2p8a637deae7de1829f54614e09d5fde5e5@epcms2p8>
2023-05-08  8:10 ` [PATCH v6] f2fs: add async reset zone command support Daejun Park
2023-05-09 18:53   ` Jaegeuk Kim
2023-05-23 14:43     ` Steven Rostedt [this message]
2023-05-25  1:20     ` Chao Yu
     [not found]   ` <CGME20230508081042epcms2p8a637deae7de1829f54614e09d5fde5e5@epcms2p6>
2023-05-11  5:24     ` Daejun Park
2023-05-18  1:05       ` (2) " Jaegeuk Kim
     [not found]       ` <CGME20230508081042epcms2p8a637deae7de1829f54614e09d5fde5e5@epcms2p7>
2023-05-18  2:08         ` Daejun Park
2023-05-24  1:19           ` (2) " Jaegeuk Kim
2023-05-30 23:40   ` [f2fs-dev] " patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523104347.61149ecd@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=beomsu7.kim@samsung.com \
    --cc=chao@kernel.org \
    --cc=daejun7.park@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=sukka.kim@samsung.com \
    --cc=yonggil.song@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).