From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C37C7EE2E for ; Fri, 9 Jun 2023 07:23:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230372AbjFIHXG (ORCPT ); Fri, 9 Jun 2023 03:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238641AbjFIHWw (ORCPT ); Fri, 9 Jun 2023 03:22:52 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA2351712; Fri, 9 Jun 2023 00:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686295370; x=1717831370; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=82UYhh7EzWzGbwx2ugDFENfvhDkwZhvC12M3ucabpw4=; b=AG+t2NUTKEjZOb2ZWj1KQkvtnjPleHRB9YzzaqkTq71F5YpE8tKVjkKG 3OwxE8ugGr9dwDpAzxjhHlPIae2B+8XnOKdARdIeT/yxlKwwe/DII5B38 y2v9tH+BCu83tAA8U9g9vmJ92x1XcNxxkp+58LiYTK+ZFTY1uZaNDLIYR m/dkJIUUIP8hUZMjT9KQEPC0HeBamtqK1bRf9MNovDLls5jJYI7BRXK1R guU6BKgnIs8StGFstM+TeR7WC9xqStroNG0k2YX7tc94gBCdLQ0i6lizv LaDi5ZbZaJrfphxYpmWVrKtJhpXme4vm6Fix+thO/UX4gO8r1TRZVfl8Q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="443905947" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="443905947" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 00:22:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="1040408104" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="1040408104" Received: from lkp-server01.sh.intel.com (HELO 15ab08e44a81) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 09 Jun 2023 00:22:48 -0700 Received: from kbuild by 15ab08e44a81 with local (Exim 4.96) (envelope-from ) id 1q7WSN-0008lS-26; Fri, 09 Jun 2023 07:22:47 +0000 Date: Fri, 9 Jun 2023 15:22:26 +0800 From: kernel test robot To: Naveen N Rao , linux-trace-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Steven Rostedt , Masami Hiramatsu , Srikar Dronamraju , linux-kernel@vger.kernel.org Subject: Re: [PATCH] trace/kprobe: Display the actual notrace function when rejecting a probe Message-ID: <202306091507.njZTnqSN-lkp@intel.com> References: <20230609045545.418677-1-naveen@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609045545.418677-1-naveen@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org Hi Naveen, kernel test robot noticed the following build errors: [auto build test ERROR on e46ad59233cf16daf4f3b9dd080003f01ac940fe] url: https://github.com/intel-lab-lkp/linux/commits/Naveen-N-Rao/trace-kprobe-Display-the-actual-notrace-function-when-rejecting-a-probe/20230609-125904 base: e46ad59233cf16daf4f3b9dd080003f01ac940fe patch link: https://lore.kernel.org/r/20230609045545.418677-1-naveen%40kernel.org patch subject: [PATCH] trace/kprobe: Display the actual notrace function when rejecting a probe config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20230609/202306091507.njZTnqSN-lkp@intel.com/config) compiler: mips-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout e46ad59233cf16daf4f3b9dd080003f01ac940fe b4 shazam https://lore.kernel.org/r/20230609045545.418677-1-naveen@kernel.org # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash kernel/ If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306091507.njZTnqSN-lkp@intel.com/ All errors (new ones prefixed by >>): kernel/trace/trace_kprobe.c: In function '__register_trace_kprobe': >> kernel/trace/trace_kprobe.c:490:41: error: macro "within_notrace_func" passed 2 arguments, but takes just 1 490 | if (within_notrace_func(tk, addr)) { | ^ kernel/trace/trace_kprobe.c:473: note: macro "within_notrace_func" defined here 473 | #define within_notrace_func(tk) (false) | >> kernel/trace/trace_kprobe.c:490:13: error: 'within_notrace_func' undeclared (first use in this function) 490 | if (within_notrace_func(tk, addr)) { | ^~~~~~~~~~~~~~~~~~~ kernel/trace/trace_kprobe.c:490:13: note: each undeclared identifier is reported only once for each function it appears in vim +/within_notrace_func +490 kernel/trace/trace_kprobe.c 475 476 /* Internal register function - just handle k*probes and flags */ 477 static int __register_trace_kprobe(struct trace_kprobe *tk) 478 { 479 unsigned long addr = trace_kprobe_address(tk); 480 char symname[KSYM_NAME_LEN]; 481 int i, ret; 482 483 ret = security_locked_down(LOCKDOWN_KPROBES); 484 if (ret) 485 return ret; 486 487 if (trace_kprobe_is_registered(tk)) 488 return -EINVAL; 489 > 490 if (within_notrace_func(tk, addr)) { 491 pr_warn("Could not probe notrace function %s\n", 492 lookup_symbol_name(addr, symname) ? trace_kprobe_symbol(tk) : symname); 493 return -EINVAL; 494 } 495 496 for (i = 0; i < tk->tp.nr_args; i++) { 497 ret = traceprobe_update_arg(&tk->tp.args[i]); 498 if (ret) 499 return ret; 500 } 501 502 /* Set/clear disabled flag according to tp->flag */ 503 if (trace_probe_is_enabled(&tk->tp)) 504 tk->rp.kp.flags &= ~KPROBE_FLAG_DISABLED; 505 else 506 tk->rp.kp.flags |= KPROBE_FLAG_DISABLED; 507 508 if (trace_kprobe_is_return(tk)) 509 ret = register_kretprobe(&tk->rp); 510 else 511 ret = register_kprobe(&tk->rp.kp); 512 513 return ret; 514 } 515 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki