* [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().
@ 2023-04-18 14:38 Sebastian Andrzej Siewior
2023-04-18 15:24 ` Mukesh Ojha
2023-04-24 21:44 ` Steven Rostedt
0 siblings, 2 replies; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2023-04-18 14:38 UTC (permalink / raw)
To: linux-kernel, linux-trace-kernel
Cc: Steven Rostedt, Masami Hiramatsu, Thomas Gleixner
The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
since these modes are not decoded. The author was not aware of the fancy
decoding function which makes the life easier.
Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
modes.
Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
include/trace/events/timer.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
index 2e713a7d9aa3a..5d43751a766c6 100644
--- a/include/trace/events/timer.h
+++ b/include/trace/events/timer.h
@@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel,
{ HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \
{ HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \
{ HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \
- { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" })
+ { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \
+ { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \
+ { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \
+ { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \
+ { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" })
/**
* hrtimer_init - called when the hrtimer is initialized
--
2.40.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().
2023-04-18 14:38 [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode() Sebastian Andrzej Siewior
@ 2023-04-18 15:24 ` Mukesh Ojha
2023-04-24 21:44 ` Steven Rostedt
1 sibling, 0 replies; 6+ messages in thread
From: Mukesh Ojha @ 2023-04-18 15:24 UTC (permalink / raw)
To: Sebastian Andrzej Siewior, linux-kernel, linux-trace-kernel
Cc: Steven Rostedt, Masami Hiramatsu, Thomas Gleixner
On 4/18/2023 8:08 PM, Sebastian Andrzej Siewior wrote:
> The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> since these modes are not decoded. The author was not aware of the fancy
> decoding function which makes the life easier.
>
> Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> modes.
>
> Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Good catch.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> ---
> include/trace/events/timer.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
> index 2e713a7d9aa3a..5d43751a766c6 100644
> --- a/include/trace/events/timer.h
> +++ b/include/trace/events/timer.h
> @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel,
> { HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \
> { HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \
> { HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \
> - { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" })
> + { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \
> + { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \
> + { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \
> + { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \
> + { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" })
>
> /**
> * hrtimer_init - called when the hrtimer is initialized
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().
2023-04-18 14:38 [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode() Sebastian Andrzej Siewior
2023-04-18 15:24 ` Mukesh Ojha
@ 2023-04-24 21:44 ` Steven Rostedt
2023-05-24 15:39 ` Sebastian Andrzej Siewior
1 sibling, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2023-04-24 21:44 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-kernel, linux-trace-kernel, Masami Hiramatsu,
Thomas Gleixner
On Tue, 18 Apr 2023 16:38:54 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> since these modes are not decoded. The author was not aware of the fancy
> decoding function which makes the life easier.
>
> Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> modes.
>
> Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().
2023-04-24 21:44 ` Steven Rostedt
@ 2023-05-24 15:39 ` Sebastian Andrzej Siewior
2023-05-25 0:25 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2023-05-24 15:39 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, linux-trace-kernel, Masami Hiramatsu,
Thomas Gleixner
On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote:
> On Tue, 18 Apr 2023 16:38:54 +0200
> Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>
> > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> > since these modes are not decoded. The author was not aware of the fancy
> > decoding function which makes the life easier.
> >
> > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> > modes.
> >
> > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Could this be either routed via the tracing tree or the tip tree but
please route this :)
Sebastian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().
2023-05-24 15:39 ` Sebastian Andrzej Siewior
@ 2023-05-25 0:25 ` Steven Rostedt
2023-06-09 20:15 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2023-05-25 0:25 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-kernel, linux-trace-kernel, Masami Hiramatsu,
Thomas Gleixner
On Wed, 24 May 2023 17:39:28 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote:
> > On Tue, 18 Apr 2023 16:38:54 +0200
> > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> >
> > > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> > > since these modes are not decoded. The author was not aware of the fancy
> > > decoding function which makes the life easier.
> > >
> > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> > > modes.
> > >
> > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> >
> > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
> Could this be either routed via the tracing tree or the tip tree but
> please route this :)
>
Events are normally owned by the subsystem they are used in. So it
should go through tip. But if I get an ack from the subsystem
maintainer, I can route it through tracing.
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-09 20:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-18 14:38 [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode() Sebastian Andrzej Siewior
2023-04-18 15:24 ` Mukesh Ojha
2023-04-24 21:44 ` Steven Rostedt
2023-05-24 15:39 ` Sebastian Andrzej Siewior
2023-05-25 0:25 ` Steven Rostedt
2023-06-09 20:15 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).