From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE164C7EE43 for ; Fri, 9 Jun 2023 21:46:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231560AbjFIVqc (ORCPT ); Fri, 9 Jun 2023 17:46:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjFIVqc (ORCPT ); Fri, 9 Jun 2023 17:46:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10C6D35BE; Fri, 9 Jun 2023 14:46:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A284665C70; Fri, 9 Jun 2023 21:46:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4653CC433D2; Fri, 9 Jun 2023 21:46:29 +0000 (UTC) Date: Fri, 9 Jun 2023 17:46:26 -0400 From: Steven Rostedt To: Zheng Yejian Cc: , , , , , Shuah Khan Subject: Re: [PATCH] selftests/ftrace: Test toplevel-enable for instance Message-ID: <20230609174626.66659892@gandalf.local.home> In-Reply-To: <20230509203659.1173917-1-zhengyejian1@huawei.com> References: <20230509203659.1173917-1-zhengyejian1@huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Wed, 10 May 2023 04:36:59 +0800 Zheng Yejian wrote: > 'available_events' is actually not required by > 'test.d/event/toplevel-enable.tc' and its Existence has been tested in > 'test.d/00basic/basic4.tc'. > > So the require of 'available_events' can be dropped and then we can add > 'instance' flag to test 'test.d/event/toplevel-enable.tc' for instance. > > Test result show as below: > # ./ftracetest test.d/event/toplevel-enable.tc > === Ftrace unit tests === > [1] event tracing - enable/disable with top level files [PASS] > [2] (instance) event tracing - enable/disable with top level files [PASS] > > # of passed: 2 > # of failed: 0 > # of unresolved: 0 > # of untested: 0 > # of unsupported: 0 > # of xfailed: 0 > # of undefined(test bug): 0 > > Signed-off-by: Zheng Yejian Acked-by: Steven Rostedt (Google) -- Steve > --- > tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > index 93c10ea42a68..8b8e1aea985b 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > @@ -1,7 +1,8 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # description: event tracing - enable/disable with top level files > -# requires: available_events set_event events/enable > +# requires: set_event events/enable > +# flags: instance > > do_reset() { > echo > set_event