* [PATCH] selftests/ftace: Fix KTAP output ordering
@ 2023-06-10 14:27 Mark Brown
2023-06-12 5:33 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2023-06-10 14:27 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Shuah Khan
Cc: Shuah Khan, linux-kernel, linux-trace-kernel, linux-kselftest,
Mark Brown
The KTAP parser I used to test the KTAP output for ftracetest was overly
robust and did not notice that the test number and pass/fail result were
reversed. Fix this.
Fixes: dbcf76390eb9 ("elftests/ftrace: Improve integration with kselftest runner")
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/ftrace/ftracetest | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 2506621e75df..cb5f18c06593 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -301,7 +301,7 @@ ktaptest() { # result comment
comment="# $comment"
fi
- echo $CASENO $result $INSTANCE$CASENAME $comment
+ echo $result $CASENO $INSTANCE$CASENAME $comment
}
eval_result() { # sigval
---
base-commit: dbcf76390eb9a65d5d0c37b0cd57335218564e37
change-id: 20230609-ftrace-ktap-order-d5b64a74dc79
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/ftace: Fix KTAP output ordering
2023-06-10 14:27 [PATCH] selftests/ftace: Fix KTAP output ordering Mark Brown
@ 2023-06-12 5:33 ` Masami Hiramatsu
2023-06-12 14:10 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2023-06-12 5:33 UTC (permalink / raw)
To: Mark Brown
Cc: Steven Rostedt, Shuah Khan, Shuah Khan, linux-kernel,
linux-trace-kernel, linux-kselftest
On Sat, 10 Jun 2023 15:27:55 +0100
Mark Brown <broonie@kernel.org> wrote:
> The KTAP parser I used to test the KTAP output for ftracetest was overly
> robust and did not notice that the test number and pass/fail result were
> reversed. Fix this.
Oops, I also missed that part. According to the Documentation/dev-tools/ktap.rst,
the result string ('ok', 'not ok') must be the first item.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Shuah, could you pick this?
Thank you,
>
> Fixes: dbcf76390eb9 ("elftests/ftrace: Improve integration with kselftest runner")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> tools/testing/selftests/ftrace/ftracetest | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 2506621e75df..cb5f18c06593 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -301,7 +301,7 @@ ktaptest() { # result comment
> comment="# $comment"
> fi
>
> - echo $CASENO $result $INSTANCE$CASENAME $comment
> + echo $result $CASENO $INSTANCE$CASENAME $comment
> }
>
> eval_result() { # sigval
>
> ---
> base-commit: dbcf76390eb9a65d5d0c37b0cd57335218564e37
> change-id: 20230609-ftrace-ktap-order-d5b64a74dc79
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/ftace: Fix KTAP output ordering
2023-06-12 5:33 ` Masami Hiramatsu
@ 2023-06-12 14:10 ` Steven Rostedt
2023-06-12 22:42 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2023-06-12 14:10 UTC (permalink / raw)
To: Masami Hiramatsu (Google)
Cc: Mark Brown, Shuah Khan, Shuah Khan, linux-kernel,
linux-trace-kernel, linux-kselftest
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Shuah, could you pick this?
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftace: Fix KTAP output ordering
2023-06-12 14:10 ` Steven Rostedt
@ 2023-06-12 22:42 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2023-06-12 22:42 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu (Google)
Cc: Mark Brown, Shuah Khan, linux-kernel, linux-trace-kernel,
linux-kselftest, Shuah Khan
On 6/12/23 08:10, Steven Rostedt wrote:
>
>> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>>
>> Shuah, could you pick this?
>
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
> -- Steve
Applied to linux-kselftest next for Linux 6.5-rc1.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-12 22:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-10 14:27 [PATCH] selftests/ftace: Fix KTAP output ordering Mark Brown
2023-06-12 5:33 ` Masami Hiramatsu
2023-06-12 14:10 ` Steven Rostedt
2023-06-12 22:42 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).