From: Kees Cook <keescook@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, ebiggers@kernel.org,
azeemshaikh38@gmail.com, linux-trace-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing/boot: Replace strlcpy with strscpy
Date: Tue, 20 Jun 2023 13:35:14 -0700 [thread overview]
Message-ID: <202306201335.D6D772A@keescook> (raw)
In-Reply-To: <20230620163325.35c9203c@gandalf.local.home>
On Tue, Jun 20, 2023 at 04:33:25PM -0400, Steven Rostedt wrote:
> On Tue, 20 Jun 2023 13:28:26 -0700
> Kees Cook <keescook@chromium.org> wrote:
>
> > On Thu, 15 Jun 2023 18:04:20 +0000, Azeem Shaikh wrote:
> > > strlcpy() reads the entire source buffer first.
> > > This read may exceed the destination size limit.
> > > This is both inefficient and can lead to linear read
> > > overflows if a source string is not NUL-terminated [1].
> > > In an effort to remove strlcpy() completely [2], replace
> > > strlcpy() here with strscpy().
> > >
> > > [...]
> >
> > Applied to for-next/hardening, thanks!
> >
> > [1/1] tracing/boot: Replace strlcpy with strscpy
> > https://git.kernel.org/kees/c/b1c38314f756
> >
>
> I was going to add this to my queue.
Ah, okay, no worries. I will drop it from mine.
--
Kees Cook
next prev parent reply other threads:[~2023-06-20 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 18:04 [PATCH v2] tracing/boot: Replace strlcpy with strscpy Azeem Shaikh
2023-06-18 22:30 ` Masami Hiramatsu
2023-06-20 20:28 ` Kees Cook
2023-06-20 20:33 ` Steven Rostedt
2023-06-20 20:35 ` Kees Cook [this message]
2023-07-04 13:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306201335.D6D772A@keescook \
--to=keescook@chromium.org \
--cc=azeemshaikh38@gmail.com \
--cc=ebiggers@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).