From: Steven Rostedt <rostedt@goodmis.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: sunliming <sunliming@kylinos.cn>,
mhiramat@kernel.org, kelulanainsley@gmail.com,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] selftests/user_events: Add test cases when event is diabled
Date: Thu, 22 Jun 2023 16:30:36 -0400 [thread overview]
Message-ID: <20230622163036.1e68d25b@gandalf.local.home> (raw)
In-Reply-To: <ZJSuvC9bfcTQMWvI@CPC-beaub-VBQ1L.localdomain>
On Thu, 22 Jun 2023 20:27:40 +0000
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> On Wed, Jun 21, 2023 at 02:35:02PM +0800, sunliming wrote:
> > When user_events are disabled, it's write operation should return zero.
> > Add this test cases.
> >
> > Signed-off-by: sunliming <sunliming@kylinos.cn>
>
> I don't have a problem with the chagne to the test, however, the patch
> title has a typo in it for "disabled" that should be corrected. I've
> ACK'd the other 2 patches, so you only need to resubmit this one with a
> correct title.
Ah, I misunderstood when we talked earlier today. I thought the typo was in
the text of the start selftest. That is, it was part of the patch.
For a typo in the subject, I can make that fix when I pulled it in. I just
avoid touching content of the patch itself.
Care to ack it?
Thanks!
-- Steve
next prev parent reply other threads:[~2023-06-22 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 6:35 [PATCH v3 3/3] selftests/user_events: Add test cases when event is diabled sunliming
2023-06-22 20:27 ` Beau Belgrave
2023-06-22 20:30 ` Steven Rostedt [this message]
2023-06-22 20:50 ` Beau Belgrave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622163036.1e68d25b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=beaub@linux.microsoft.com \
--cc=kelulanainsley@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=sunliming@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox