* Re: [PATCH v2 77/92] tracefs: convert to ctime accessor functions
2023-07-05 19:01 ` [PATCH v2 77/92] tracefs: convert to ctime accessor functions Jeff Layton
@ 2023-07-06 14:06 ` Jan Kara
2023-07-06 14:27 ` Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2023-07-06 14:06 UTC (permalink / raw)
To: Jeff Layton
Cc: Christian Brauner, Steven Rostedt, Masami Hiramatsu, Al Viro,
Jan Kara, linux-fsdevel, linux-kernel, linux-trace-kernel
On Wed 05-07-23 15:01:42, Jeff Layton wrote:
> In later patches, we're going to change how the inode's ctime field is
> used. Switch to using accessor functions instead of raw accesses of
> inode->i_ctime.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/tracefs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
> index 57ac8aa4a724..2feb6c58648c 100644
> --- a/fs/tracefs/inode.c
> +++ b/fs/tracefs/inode.c
> @@ -132,7 +132,7 @@ static struct inode *tracefs_get_inode(struct super_block *sb)
> struct inode *inode = new_inode(sb);
> if (inode) {
> inode->i_ino = get_next_ino();
> - inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
> + inode->i_atime = inode->i_mtime = inode_set_ctime_current(inode);
> }
> return inode;
> }
> --
> 2.41.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 77/92] tracefs: convert to ctime accessor functions
2023-07-05 19:01 ` [PATCH v2 77/92] tracefs: convert to ctime accessor functions Jeff Layton
2023-07-06 14:06 ` Jan Kara
@ 2023-07-06 14:27 ` Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2023-07-06 14:27 UTC (permalink / raw)
To: Jeff Layton
Cc: Christian Brauner, Masami Hiramatsu, Al Viro, Jan Kara,
linux-fsdevel, linux-kernel, linux-trace-kernel
On Wed, 5 Jul 2023 15:01:42 -0400
Jeff Layton <jlayton@kernel.org> wrote:
> In later patches, we're going to change how the inode's ctime field is
> used. Switch to using accessor functions instead of raw accesses of
> inode->i_ctime.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/tracefs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
> index 57ac8aa4a724..2feb6c58648c 100644
> --- a/fs/tracefs/inode.c
> +++ b/fs/tracefs/inode.c
> @@ -132,7 +132,7 @@ static struct inode *tracefs_get_inode(struct super_block *sb)
> struct inode *inode = new_inode(sb);
> if (inode) {
> inode->i_ino = get_next_ino();
> - inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
> + inode->i_atime = inode->i_mtime = inode_set_ctime_current(inode);
> }
> return inode;
> }
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread