From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46B0EB64D9 for ; Thu, 6 Jul 2023 14:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232965AbjGFOG5 (ORCPT ); Thu, 6 Jul 2023 10:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232805AbjGFOGy (ORCPT ); Thu, 6 Jul 2023 10:06:54 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0F9D1BD2; Thu, 6 Jul 2023 07:06:34 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6DE49228AD; Thu, 6 Jul 2023 14:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688652393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uu4jxlXZN8L7Iwvf7kLgcAyxw4lB/q/GPbZQywpd7PY=; b=Zl0iQRbZu6oktjjwtYUjw8nIKaTAF3LKE1mcNx53LHi4IijRY57FjTOd0k6WUea8qyXMeM xXdhOPmSD635HfWazH9UoCOxl8IE6JAwWhPb3coxctrO82XKTe6us9IqlzZoNtN5OFQivb 2/rkSu9HHLwsqSbjEkPB6rKNNWJmuMM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688652393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uu4jxlXZN8L7Iwvf7kLgcAyxw4lB/q/GPbZQywpd7PY=; b=hBUvMMaz3j1QuRcfRZYsqO7BQLGGbJNwVzwFPdgua7LgAMgBfZZYZHvzm3PtAgFD8xChsG vlLHQoa+2ecBnKDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 60A7D138EE; Thu, 6 Jul 2023 14:06:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id u2aPF2nKpmTTagAAMHmgww (envelope-from ); Thu, 06 Jul 2023 14:06:33 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 007B0A0707; Thu, 6 Jul 2023 16:06:32 +0200 (CEST) Date: Thu, 6 Jul 2023 16:06:32 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Steven Rostedt , Masami Hiramatsu , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v2 77/92] tracefs: convert to ctime accessor functions Message-ID: <20230706140632.2wqxkgygalcgvjj4@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-75-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-75-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Wed 05-07-23 15:01:42, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/tracefs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c > index 57ac8aa4a724..2feb6c58648c 100644 > --- a/fs/tracefs/inode.c > +++ b/fs/tracefs/inode.c > @@ -132,7 +132,7 @@ static struct inode *tracefs_get_inode(struct super_block *sb) > struct inode *inode = new_inode(sb); > if (inode) { > inode->i_ino = get_next_ino(); > - inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); > + inode->i_atime = inode->i_mtime = inode_set_ctime_current(inode); > } > return inode; > } > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR