From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Li zeming <zeming@nfschina.com>
Cc: naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com,
davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] kprobes: Remove unnecessary ‘NULL’ values from correct_ret_addr
Date: Thu, 6 Jul 2023 22:38:24 +0900 [thread overview]
Message-ID: <20230706223824.f1eee3b3e5448dc3555c275d@kernel.org> (raw)
In-Reply-To: <20230704194359.3124-1-zeming@nfschina.com>
On Wed, 5 Jul 2023 03:43:59 +0800
Li zeming <zeming@nfschina.com> wrote:
> The 'correct_ret_addr' pointer is always set in the later code, no need
> to initialize it at definition time.
Indeed. Thanks!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index db8a3aa53cf6..ec50f9f380c1 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2007,9 +2007,9 @@ void __weak arch_kretprobe_fixup_return(struct pt_regs *regs,
> unsigned long __kretprobe_trampoline_handler(struct pt_regs *regs,
> void *frame_pointer)
> {
> - kprobe_opcode_t *correct_ret_addr = NULL;
> struct kretprobe_instance *ri = NULL;
> struct llist_node *first, *node = NULL;
> + kprobe_opcode_t *correct_ret_addr;
> struct kretprobe *rp;
>
> /* Find correct address and all nodes for this frame. */
> --
> 2.18.2
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-07-06 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 19:43 [PATCH] kprobes: Remove unnecessary ‘NULL’ values from correct_ret_addr Li zeming
2023-07-06 13:38 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706223824.f1eee3b3e5448dc3555c275d@kernel.org \
--to=mhiramat@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).