* [PATCH] kprobes: Remove unnecessary ‘NULL’ values from correct_ret_addr
@ 2023-07-04 19:43 Li zeming
2023-07-06 13:38 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2023-07-04 19:43 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat
Cc: linux-kernel, linux-trace-kernel, Li zeming
The 'correct_ret_addr' pointer is always set in the later code, no need
to initialize it at definition time.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
kernel/kprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index db8a3aa53cf6..ec50f9f380c1 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2007,9 +2007,9 @@ void __weak arch_kretprobe_fixup_return(struct pt_regs *regs,
unsigned long __kretprobe_trampoline_handler(struct pt_regs *regs,
void *frame_pointer)
{
- kprobe_opcode_t *correct_ret_addr = NULL;
struct kretprobe_instance *ri = NULL;
struct llist_node *first, *node = NULL;
+ kprobe_opcode_t *correct_ret_addr;
struct kretprobe *rp;
/* Find correct address and all nodes for this frame. */
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kprobes: Remove unnecessary ‘NULL’ values from correct_ret_addr
2023-07-04 19:43 [PATCH] kprobes: Remove unnecessary ‘NULL’ values from correct_ret_addr Li zeming
@ 2023-07-06 13:38 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2023-07-06 13:38 UTC (permalink / raw)
To: Li zeming
Cc: naveen.n.rao, anil.s.keshavamurthy, davem, linux-kernel,
linux-trace-kernel
On Wed, 5 Jul 2023 03:43:59 +0800
Li zeming <zeming@nfschina.com> wrote:
> The 'correct_ret_addr' pointer is always set in the later code, no need
> to initialize it at definition time.
Indeed. Thanks!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index db8a3aa53cf6..ec50f9f380c1 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2007,9 +2007,9 @@ void __weak arch_kretprobe_fixup_return(struct pt_regs *regs,
> unsigned long __kretprobe_trampoline_handler(struct pt_regs *regs,
> void *frame_pointer)
> {
> - kprobe_opcode_t *correct_ret_addr = NULL;
> struct kretprobe_instance *ri = NULL;
> struct llist_node *first, *node = NULL;
> + kprobe_opcode_t *correct_ret_addr;
> struct kretprobe *rp;
>
> /* Find correct address and all nodes for this frame. */
> --
> 2.18.2
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-06 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 19:43 [PATCH] kprobes: Remove unnecessary ‘NULL’ values from correct_ret_addr Li zeming
2023-07-06 13:38 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).