* [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret
@ 2023-07-04 20:10 Li zeming
2023-07-06 13:40 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2023-07-04 20:10 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat
Cc: linux-kernel, linux-trace-kernel, Li zeming
ret is assigned first, so it does not need to initialize the assignment.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
kernel/kprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index ec50f9f380c1..a009c8ccd8ea 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
static int __init init_kprobes(void)
{
- int i, err = 0;
+ int i, err;
/* FIXME allocate the probe table, currently defined statically */
/* initialize all list heads */
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret
2023-07-04 20:10 [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret Li zeming
@ 2023-07-06 13:40 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2023-07-06 13:40 UTC (permalink / raw)
To: Li zeming
Cc: naveen.n.rao, anil.s.keshavamurthy, davem, linux-kernel,
linux-trace-kernel
On Wed, 5 Jul 2023 04:10:56 +0800
Li zeming <zeming@nfschina.com> wrote:
> ret is assigned first, so it does not need to initialize the assignment.
>
OK, but can you merge this to the first one?
https://lore.kernel.org/all/20230704192107.2944-1-zeming@nfschina.com/
Thank you,
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index ec50f9f380c1..a009c8ccd8ea 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
>
> static int __init init_kprobes(void)
> {
> - int i, err = 0;
> + int i, err;
>
> /* FIXME allocate the probe table, currently defined statically */
> /* initialize all list heads */
> --
> 2.18.2
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-06 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 20:10 [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret Li zeming
2023-07-06 13:40 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).