From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] tracing/probes: Fix return value when "(fault)" is injected
Date: Fri, 7 Jul 2023 15:54:57 +0900 [thread overview]
Message-ID: <20230707155457.1ec90d8b14e66fe0efbb3699@kernel.org> (raw)
In-Reply-To: <20230706230642.3793a593@rorschach.local.home>
On Thu, 6 Jul 2023 23:06:42 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 7 Jul 2023 11:51:28 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> > Ah, I meant that your commit 2e9906f84fc7 ("tracing: Add "(fault)" name injection
> > to kernel probes") tries to make it '"(fault)"', So it makes
> >
> > trace-cmd-4688 [000] ...1. 466968.015879: myopen: (syscalls.sys_enter_openat) file="(fault)"
> >
> > Keeping it current '(fault)' makes easy to identify which one is failed to fetch,
> > but it may require user to parse both "some string" and (fault). I thought that
> > was the reason why you added that commit.
>
> Hmm, That commit didn't explicitly add the double quotes. That may just
> have been a side effect of passing back the string?
>
> But I agree, just (fault) instead of "(fault)" is more explicit that it
> faulted.
OK, let me revert that commit and clarify what the data_loc data should be
with fault case.
Thank you,
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-07-07 6:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 14:47 [PATCH 0/3] tracing/probes: Fix bugs in process_fetch_insn Masami Hiramatsu (Google)
2023-07-02 14:47 ` [PATCH 1/3] tracing/probes: Fix to avoid double count of the string length on the array Masami Hiramatsu (Google)
[not found] ` <25bd757c-f929-0153-4c94-f0502c5d1005@web.de>
2023-07-03 8:21 ` Masami Hiramatsu
2023-07-02 14:47 ` [PATCH 2/3] tracing/probes: Fix to exit fetching if an error is detected Masami Hiramatsu (Google)
2023-07-07 7:07 ` Masami Hiramatsu
2023-07-02 14:47 ` [PATCH 3/3] tracing/probes: Fix return value when "(fault)" is injected Masami Hiramatsu (Google)
2023-07-06 2:49 ` Steven Rostedt
2023-07-06 4:40 ` Masami Hiramatsu
2023-07-06 13:50 ` Steven Rostedt
2023-07-07 2:02 ` Masami Hiramatsu
2023-07-07 2:20 ` Steven Rostedt
2023-07-07 2:51 ` Masami Hiramatsu
2023-07-07 3:06 ` Steven Rostedt
2023-07-07 6:54 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707155457.1ec90d8b14e66fe0efbb3699@kernel.org \
--to=mhiramat@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).