linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mark Brown" <broonie@kernel.org>,
	"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
	"Yang Yingliang" <yangyingliang@huawei.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Amit Kumar Mahapatra via Alsa-devel"
	<alsa-devel@alsa-project.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Tharun Kumar P" <tharunkumar.pasumarthi@microchip.com>,
	"Vijaya Krishna Nivarthi" <quic_vnivarth@quicinc.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-riscv@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Sanjay R Mehta <sanju.mehta@amd.com>,
	Radu Pirea <radu_nicolae.pirea@upb.ro>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Serge Semin <fancer.lancer@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Alain Volmat <alain.volmat@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>
Subject: [PATCH v2 06/15] spi: Use sysfs_emit() to instead of s*printf()
Date: Mon, 10 Jul 2023 18:49:23 +0300	[thread overview]
Message-ID: <20230710154932.68377-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 46cbda383228..cfb1c985d940 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -64,7 +64,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf)
 	if (len != -ENODEV)
 		return len;
 
-	return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias);
+	return sysfs_emit(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias);
 }
 static DEVICE_ATTR_RO(modalias);
 
@@ -89,7 +89,7 @@ static ssize_t driver_override_show(struct device *dev,
 	ssize_t len;
 
 	device_lock(dev);
-	len = snprintf(buf, PAGE_SIZE, "%s\n", spi->driver_override ? : "");
+	len = sysfs_emit(buf, "%s\n", spi->driver_override ? : "");
 	device_unlock(dev);
 	return len;
 }
@@ -2782,8 +2782,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
 	struct device *child;
 
 	child = device_find_any_child(&ctlr->dev);
-	return sprintf(buf, "%s\n",
-		       child ? to_spi_device(child)->modalias : NULL);
+	return sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL);
 }
 
 static ssize_t slave_store(struct device *dev, struct device_attribute *attr,
-- 
2.40.0.1.gaa8946217a0b


  parent reply	other threads:[~2023-07-10 15:49 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 15:49 [PATCH v2 00/15] spi: Header and core clean up and refactoring Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 01/15] spi: Remove unneeded OF node NULL checks Andy Shevchenko
2023-07-11  8:12   ` AngeloGioacchino Del Regno
2023-07-11 12:51     ` Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 02/15] spi: Drop duplicate IDR allocation code in spi_register_controller() Andy Shevchenko
2023-07-10 17:09   ` Mark Brown
2023-07-11 10:58     ` Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 03/15] spi: Replace if-else-if by bitops and multiplications Andy Shevchenko
2023-07-10 16:56   ` Mark Brown
2023-07-11 10:58     ` Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 04/15] spi: Replace open coded spi_controller_xfer_timeout() Andy Shevchenko
2023-07-10 17:30   ` Mark Brown
2023-07-11 11:01     ` Andy Shevchenko
2023-07-11 14:14       ` Mark Brown
2023-07-11 15:30         ` Andy Shevchenko
2023-07-11 15:49           ` Mark Brown
2023-07-11  8:28   ` AngeloGioacchino Del Regno
2023-07-11 13:05     ` Mark Brown
2023-07-11 13:29       ` AngeloGioacchino Del Regno
2023-07-10 15:49 ` [PATCH v2 05/15] spi: Remove code duplication in spi_add_device_locked() Andy Shevchenko
2023-07-10 17:16   ` Mark Brown
2023-07-11 11:06     ` Andy Shevchenko
2023-07-11 12:01       ` Sebastian Reichel
2023-07-11 12:47         ` Andy Shevchenko
2023-07-10 15:49 ` Andy Shevchenko [this message]
2023-07-10 15:49 ` [PATCH v2 07/15] spi: Sort headers alphabetically Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 08/15] spi: Clean up headers Andy Shevchenko
2023-07-10 17:21   ` Mark Brown
2023-07-11 11:10     ` Andy Shevchenko
2023-07-11  8:26   ` Mark Brown
2023-07-11 11:10     ` Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 09/15] spi: Use struct_size() helper Andy Shevchenko
2023-07-10 15:59   ` Marc Kleine-Budde
2023-07-10 16:10     ` Andy Shevchenko
2023-07-10 16:12       ` Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 10/15] spi: Use predefined constants from bits.h and units.h Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 11/15] spi: Get rid of old SPI_MASTER_NO_TX & SPI_MASTER_NO_RX Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 12/15] spi: Get rid of old SPI_MASTER_MUST_TX & SPI_MASTER_MUST_RX Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 13/15] spi: Rename SPI_MASTER_GPIO_SS to SPI_CONTROLLER_GPIO_SS Andy Shevchenko
2023-07-11 12:30   ` Serge Semin
2023-07-11 12:49     ` Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 14/15] spi: Convert to SPI_CONTROLLER_HALF_DUPLEX Andy Shevchenko
2023-07-10 15:49 ` [PATCH v2 15/15] spi: Fix spelling typos and acronyms capitalization Andy Shevchenko
2023-07-10 17:31 ` [PATCH v2 00/15] spi: Header and core clean up and refactoring Mark Brown
2023-07-11 11:11   ` Andy Shevchenko
2023-07-11 13:38     ` Mark Brown
2023-07-11 13:45       ` Andy Shevchenko
2023-07-12 11:47 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710154932.68377-7-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=agross@kernel.org \
    --cc=alain.volmat@foss.st.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea@microchip.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=fancer.lancer@gmail.com \
    --cc=festevam@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jbrunet@baylibre.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=orsonzhai@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=quic_vnivarth@quicinc.com \
    --cc=radu_nicolae.pirea@upb.ro \
    --cc=richardcochran@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sanju.mehta@amd.com \
    --cc=shawnguo@kernel.org \
    --cc=tharunkumar.pasumarthi@microchip.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yangyingliang@huawei.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).