From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F40DEB64D9 for ; Tue, 11 Jul 2023 01:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230213AbjGKBdL (ORCPT ); Mon, 10 Jul 2023 21:33:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbjGKBdL (ORCPT ); Mon, 10 Jul 2023 21:33:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3EDE3; Mon, 10 Jul 2023 18:33:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0248C612AC; Tue, 11 Jul 2023 01:33:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D6FDC433C7; Tue, 11 Jul 2023 01:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689039189; bh=QDRQnHoafNPtNndmmJCDWbHEn5BC5mW3Cf6B9Yi5nl8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l8YVL43Fe8WkS6hWTx2bCObBHxOUXiVmbo5XicQGBS+PjHV6Lo2azCINCXtGiXKDa y5aoJ+mlPz6Ar8RSzrA3Na96HB9HijQCsCAEPS0dIMBdT26HJ96jM/+ghOzscwmXc1 n2zjXqIiPtktTjUO90LIM+SlUBz2xE8Kq7qz5byNveFSme2/TiwKWlQ11tFlptm0fX EhDoZOaAGG5lII2TNWKgE+Qmznz+4DanrLE0y9FvIEm/t0VUvexenmMM83bxiN34zr rr62LTaB4MjT2fNEv+1pj0Y3mPkI2iilPM2hgzBPHDJvzxYIWS2WihwNfD49BqMg4Q glb+i/SGPeLzQ== Date: Tue, 11 Jul 2023 10:33:03 +0900 From: Masami Hiramatsu (Google) To: Nathan Chancellor Cc: Peter Zijlstra , Petr Pavlu , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, samitolvanen@google.com, x86@kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, ndesaulniers@google.com Subject: Re: [RFC PATCH 0/2] x86: kprobes: Fix CFI_CLANG related issues Message-Id: <20230711103303.287af608cc47dcf70d709070@kernel.org> In-Reply-To: <20230710155703.GA4021842@dev-arch.thelio-3990X> References: <168899125356.80889.17967397360941194229.stgit@devnote2> <20230710155703.GA4021842@dev-arch.thelio-3990X> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, 10 Jul 2023 08:57:03 -0700 Nathan Chancellor wrote: > On Mon, Jul 10, 2023 at 09:14:13PM +0900, Masami Hiramatsu (Google) wrote: > > I just build tested, since I could not boot the kernel with CFI_CLANG=y. > > Would anyone know something about this error? > > > > [ 0.141030] MMIO Stale Data: Unknown: No mitigations > > [ 0.153511] SMP alternatives: Using kCFI > > [ 0.164593] Freeing SMP alternatives memory: 36K > > [ 0.165053] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: start_kernel+0x472/0x48b > > [ 0.166028] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.4.2-00002-g12b1b2fca8ef #126 > > [ 0.166028] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 > > [ 0.166028] Call Trace: > > [ 0.166028] > > [ 0.166028] dump_stack_lvl+0x6e/0xb0 > > [ 0.166028] panic+0x146/0x2f0 > > [ 0.166028] ? start_kernel+0x472/0x48b > > [ 0.166028] __stack_chk_fail+0x14/0x20 > > [ 0.166028] start_kernel+0x472/0x48b > > [ 0.166028] x86_64_start_reservations+0x24/0x30 > > [ 0.166028] x86_64_start_kernel+0xa6/0xbb > > [ 0.166028] secondary_startup_64_no_verify+0x106/0x11b > > [ 0.166028] > > [ 0.166028] ---[ end Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: start_kernel+0x472/0x48b ]--- > > This looks like https://github.com/ClangBuiltLinux/linux/issues/1815 to > me. What version of LLVM are you using? This was fixed in 16.0.4. Commit > 514ca14ed544 ("start_kernel: Add __no_stack_protector function > attribute") should resolve it on the Linux side, it looks like that is > in 6.5-rc1. Not sure if we should backport it or just let people upgrade > their toolchains on older releases. Thanks for the info. I confirmed that the commit fixed the boot issue. So I think it should be backported to the stable tree. Thanks! > > Cheers, > Nathan -- Masami Hiramatsu (Google)