Re: [PATCH v4 00/10] tracing: introducing eventfs

Steven Rostedt
2023-07-21T20:40:24Z

On Fri, 21 Jul 2023 09:19:47 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > + } else {
> > + /* A race here, should try again (unless freed) */
> > + invalidate = true;
>
> I had a WARN_ON() once here. Probably could add a:
>
> WARN_ON_ONCE(!ef->is_freed);

Yeah this should have a WARN_ON_ONCE() because the only way to get here
with having a dentry and the ef->dentry being set is if we have two
dentries with the same name in the same directory. Which should never
happen.

I think we can add:

/*
* Should never happen unless we get here due to being freed.
* Otherwise it means two dentries exist with the same name.
*/
WARN_ON_ONCE(!ef->is_freed);

>
> > + }

-- Steve