From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B87EB64DC for ; Tue, 18 Jul 2023 01:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbjGRBED (ORCPT ); Mon, 17 Jul 2023 21:04:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230368AbjGRBDx (ORCPT ); Mon, 17 Jul 2023 21:03:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E477810F0; Mon, 17 Jul 2023 18:03:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B00B61343; Tue, 18 Jul 2023 01:03:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ACACC433C7; Tue, 18 Jul 2023 01:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689642229; bh=5k/u+A5DX4GHss2OEjzlFsWIQoVIRmvHHG7d/qfjoYE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Tq3zbcMlte9vBm6Qt/pdcZjvS/qKfvD/EqAQhRWt24pLiMmQ8nsx5hmUCyYpzMnkP p3rS5xu7Or7QTSHKU1SHT776uRC4KE93j6Mf8aXGdVHd+LBYVdfjbtZIOfxx/Millz TmULkOlG/sIjNfWWfK1K6KT9VSxf6ZcPk1Wj+XxgxCDR57h96P7GyMZjm0BOPQlb7y G8yzf/oypKldVEr21OyRlpOOZyL4Vp1Wrgy+xZw10nYHmxZKAqEPtVw+urMBnXOWa1 dkaTfuzTsqwiyFTSsyK/UJTl7deaatLgcRLR81nHyW2Q+mF60i1nnkU0NkmPABQQMX CSeufJmFvIgJQ== Date: Tue, 18 Jul 2023 10:03:45 +0900 From: Masami Hiramatsu (Google) To: Alexei Starovoitov Cc: Steven Rostedt , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Sven Schnelle , Alexei Starovoitov Subject: Re: [PATCH v2 2/9] bpf/btf: tracing: Move finding func-proto API and getting func-param API to BTF Message-Id: <20230718100345.c4ba0e4c1e52e9b028697f98@kernel.org> In-Reply-To: References: <168960739768.34107.15145201749042174448.stgit@devnote2> <168960741686.34107.6330273416064011062.stgit@devnote2> <20230717143914.5399a8e4@gandalf.local.home> <20230718084634.7746b16b470f5fa1b0d99521@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, 17 Jul 2023 16:51:29 -0700 Alexei Starovoitov wrote: > On Mon, Jul 17, 2023 at 4:46 PM Masami Hiramatsu wrote: > > > > > > > > > + * Return NULL if not found, or return -EINVAL if parameter is invalid. > > > > + */ > > > > +const struct btf_type *btf_find_func_proto(struct btf *btf, const char *func_name) > > > > +{ > > > > + const struct btf_type *t; > > > > + s32 id; > > > > + > > > > + if (!btf || !func_name) > > > > + return ERR_PTR(-EINVAL); > > Please remove these checks. > We don't do defensive programming in the BPF subsystem. > Don't pass NULL pointers to such functions. OK, we will trust API user to pass a non-NULL parameters. Thank you! -- Masami Hiramatsu (Google)