From: Steven Rostedt <rostedt@goodmis.org>
To: wuyonggang001@208suo.com
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: add missing spaces after ';'
Date: Thu, 20 Jul 2023 13:45:01 -0400 [thread overview]
Message-ID: <20230720134501.01f9f1de@gandalf.local.home> (raw)
In-Reply-To: <74685bd017411f96c8a846ebd5e3916a@208suo.com>
On Thu, 20 Jul 2023 10:30:36 +0800
wuyonggang001@208suo.com wrote:
> Remove spaces to clear checkpatch errors.
>
> ERROR: space required after that ';' (ctx:VxV)
PLEASE DO NOT RUN CHECKPATCH ON CURRENT CODE!!!!
As the name suggests, checkpatch is for patches and not for existing code.
It is used as a guideline tool to make clean patches. But checkpatch is
*NOT* the rule of the kernel. There's lots of issues that checkpatch
reports that can be ignored. That is decided when the patch is submitted,
and SHOULD NOT be revisited once it has been accepted. Not to mention this
particular error is silly.
NACK!!!
-- Steve
>
> Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
> ---
> include/trace/stages/stage4_event_fields.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/stages/stage4_event_fields.h
> b/include/trace/stages/stage4_event_fields.h
> index b6f679ae21aa..9627e081a990 100644
> --- a/include/trace/stages/stage4_event_fields.h
> +++ b/include/trace/stages/stage4_event_fields.h
> @@ -2,7 +2,7 @@
>
> /* Stage 4 definitions for creating trace events */
>
> -#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;})))
> +#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; })))
>
> #undef __field_ext
> #define __field_ext(_type, _item, _filter_type) { \
prev parent reply other threads:[~2023-07-20 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230719064321.19047-1-xujianghui@cdjrlc.com>
2023-07-20 2:30 ` [PATCH] tracing: add missing spaces after ';' wuyonggang001
2023-07-20 17:45 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720134501.01f9f1de@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=wuyonggang001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).