From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B01EB64DA for ; Fri, 21 Jul 2023 01:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbjGUBmJ (ORCPT ); Thu, 20 Jul 2023 21:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjGUBmH (ORCPT ); Thu, 20 Jul 2023 21:42:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 801EE2106; Thu, 20 Jul 2023 18:42:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13D3461CD3; Fri, 21 Jul 2023 01:42:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 458C4C433C9; Fri, 21 Jul 2023 01:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689903725; bh=dw1xMty5sUx55lKWIHCKf4qU6fRTTDgNxFDurgYRD1o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LTGUIWNwZCt1pvkrukTY07XnEQ3xswAAwgdRew4atcUyeBGtLAvFf5Umec9wZj+AI JdPeGtUCroBGjn0H/wVOegulnEJOYmNBACd1LCKdDO3sf8z+Ag/79dQhp2bt194Qvk g2G2A+JNUE6yNltck6xY/Dj2RORG584hKY3IghbWUoThzBjUtzjLGR00BCLycUD42Z jm4lqjPX5e3D+SiQMc5RQTWLhvt/3gDo2q8LbHYqgFt6nOkEdESWgRV7AFga1HufWR 6vhlgA/YSc959/OcEykI0a6cgsJ4/rKmb68/tS+knEIwFuRXjH56we7ZwINrbxJdNS ++IxAlVxujtGQ== Date: Fri, 21 Jul 2023 10:42:00 +0900 From: Masami Hiramatsu (Google) To: Alan Maguire Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt , Martin KaFai Lau , bpf@vger.kernel.org, Sven Schnelle , Alexei Starovoitov Subject: Re: [PATCH v2 8/9] selftests/ftrace: Add BTF fields access testcases Message-Id: <20230721104200.92655ae661532475134cf004@kernel.org> In-Reply-To: <18605821-d4f1-c8e2-74eb-a91fc06d53b7@oracle.com> References: <168960739768.34107.15145201749042174448.stgit@devnote2> <168960747750.34107.6104527579648222887.stgit@devnote2> <18605821-d4f1-c8e2-74eb-a91fc06d53b7@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Fri, 21 Jul 2023 00:00:32 +0100 Alan Maguire wrote: > > On 17/07/2023 16:24, Masami Hiramatsu (Google) wrote: > > From: Masami Hiramatsu (Google) > > > > Add test cases for accessing the data structure fields using BTF info. > > This includes the field access from parameters and retval, and accessing > > string information. > > > > Signed-off-by: Masami Hiramatsu (Google) > > One suggestion below, but > > Reviewed-by: Alan Maguire Thanks > > > --- > > Changes in v2: > > - Use '$retval' instead of 'retval'. > > - Add a test that use both '$retval' and '$arg1' for fprobe. > > --- > > .../ftrace/test.d/dynevent/add_remove_btfarg.tc | 11 +++++++++++ > > .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 4 ++++ > > 2 files changed, 15 insertions(+) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc > > index b89de1771655..93b94468967b 100644 > > --- a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc > > +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc > > @@ -21,6 +21,8 @@ echo 0 > events/enable > > echo > dynamic_events > > > > TP=kfree > > +TP2=kmem_cache_alloc > > +TP3=getname_flags > > > > if [ "$FPROBES" ] ; then > > echo "f:fpevent $TP object" >> dynamic_events > > @@ -33,6 +35,7 @@ echo > dynamic_events > > > > echo "f:fpevent $TP "'$arg1' >> dynamic_events > > grep -q "fpevent.*object=object" dynamic_events > > + > > echo > dynamic_events > > > > echo "f:fpevent $TP "'$arg*' >> dynamic_events > > @@ -45,6 +48,14 @@ fi > > > > echo > dynamic_events > > > > +echo "t:tpevent $TP2 name=s->name:string" >> dynamic_events > > +echo "f:fpevent ${TP3}%return path=\$retval->name:string" >> dynamic_events > > + > > could we test a numeric value like kmem_cache_alloc object size? > also if combos of -> and . are allowed, would be good to test one of > those too. OK, that's a good point! I'll add it. > > > +grep -q "tpevent.*name=s->name:string" dynamic_events > > +grep -q "fpevent.*path=\$retval->name:string" dynamic_events > > + > > +echo > dynamic_events > > + > > if [ "$KPROBES" ] ; then > > echo "p:kpevent $TP object" >> dynamic_events > > grep -q "kpevent.*object=object" dynamic_events > > diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > > index 72563b2e0812..49758f77c923 100644 > > --- a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > > +++ b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > > @@ -103,6 +103,10 @@ check_error 'f vfs_read%return ^$arg*' # NOFENTRY_ARGS > > check_error 'f vfs_read ^hoge' # NO_BTFARG > > check_error 'f kfree ^$arg10' # NO_BTFARG (exceed the number of parameters) > > check_error 'f kfree%return ^$retval' # NO_RETVAL > > +check_error 'f vfs_read%return $retval->^foo' # NO_PTR_STRCT > > +check_error 'f vfs_read file->^foo' # NO_BTF_FIELD > > +check_error 'f vfs_read file^-.foo' # BAD_HYPHEN > > +check_error 'f vfs_read ^file:string' # BAD_TYPE4STR > > else > > check_error 'f vfs_read ^$arg*' # NOSUP_BTFARG > > check_error 't kfree ^$arg*' # NOSUP_BTFARG > > > > -- Masami Hiramatsu (Google)