From: Steven Rostedt <rostedt@goodmis.org>
To: sunran001@208suo.com
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] napi: remove spaces after '('
Date: Sun, 23 Jul 2023 11:13:16 -0400 [thread overview]
Message-ID: <20230723111317.7aadddc0@gandalf.local.home> (raw)
In-Reply-To: <f9128b6d2307a4a53904930cae864dcc@208suo.com>
On Wed, 19 Jul 2023 14:50:11 +0800
sunran001@208suo.com wrote:
> Fix four occurrences of the checkpatch error:
>
> ERROR: space prohibited after that open parenthesis '('
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> include/trace/events/napi.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/trace/events/napi.h b/include/trace/events/napi.h
> index 6678cf8b235b..98fb9e0d2219 100644
> --- a/include/trace/events/napi.h
> +++ b/include/trace/events/napi.h
> @@ -18,10 +18,10 @@ TRACE_EVENT(napi_poll,
> TP_ARGS(napi, work, budget),
>
> TP_STRUCT__entry(
> - __field( struct napi_struct *, napi)
> - __string( dev_name, napi->dev ? napi->dev->name : NO_DEV)
> - __field( int, work)
> - __field( int, budget)
> + __field(struct napi_struct *, napi)
> + __string(dev_name, napi->dev ? napi->dev->name : NO_DEV)
> + __field(int, work)
> + __field(int, budget)
NACK!
Which version looks better?
checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM!
-- Steve
> ),
>
> TP_fast_assign(
prev parent reply other threads:[~2023-07-23 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230719032953.18679-1-xujianghui@cdjrlc.com>
2023-07-19 6:50 ` [PATCH] napi: remove spaces after '(' sunran001
2023-07-23 15:13 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230723111317.7aadddc0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=sunran001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).