* [PATCH] napi: remove spaces after '('
[not found] <20230719032953.18679-1-xujianghui@cdjrlc.com>
@ 2023-07-19 6:50 ` sunran001
2023-07-23 15:13 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: sunran001 @ 2023-07-19 6:50 UTC (permalink / raw)
To: rostedt, mhiramat; +Cc: linux-kernel, linux-trace-kernel
Fix four occurrences of the checkpatch error:
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
include/trace/events/napi.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/trace/events/napi.h b/include/trace/events/napi.h
index 6678cf8b235b..98fb9e0d2219 100644
--- a/include/trace/events/napi.h
+++ b/include/trace/events/napi.h
@@ -18,10 +18,10 @@ TRACE_EVENT(napi_poll,
TP_ARGS(napi, work, budget),
TP_STRUCT__entry(
- __field( struct napi_struct *, napi)
- __string( dev_name, napi->dev ? napi->dev->name : NO_DEV)
- __field( int, work)
- __field( int, budget)
+ __field(struct napi_struct *, napi)
+ __string(dev_name, napi->dev ? napi->dev->name : NO_DEV)
+ __field(int, work)
+ __field(int, budget)
),
TP_fast_assign(
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] napi: remove spaces after '('
2023-07-19 6:50 ` [PATCH] napi: remove spaces after '(' sunran001
@ 2023-07-23 15:13 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2023-07-23 15:13 UTC (permalink / raw)
To: sunran001; +Cc: mhiramat, linux-kernel, linux-trace-kernel
On Wed, 19 Jul 2023 14:50:11 +0800
sunran001@208suo.com wrote:
> Fix four occurrences of the checkpatch error:
>
> ERROR: space prohibited after that open parenthesis '('
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> include/trace/events/napi.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/trace/events/napi.h b/include/trace/events/napi.h
> index 6678cf8b235b..98fb9e0d2219 100644
> --- a/include/trace/events/napi.h
> +++ b/include/trace/events/napi.h
> @@ -18,10 +18,10 @@ TRACE_EVENT(napi_poll,
> TP_ARGS(napi, work, budget),
>
> TP_STRUCT__entry(
> - __field( struct napi_struct *, napi)
> - __string( dev_name, napi->dev ? napi->dev->name : NO_DEV)
> - __field( int, work)
> - __field( int, budget)
> + __field(struct napi_struct *, napi)
> + __string(dev_name, napi->dev ? napi->dev->name : NO_DEV)
> + __field(int, work)
> + __field(int, budget)
NACK!
Which version looks better?
checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM!
-- Steve
> ),
>
> TP_fast_assign(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-23 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230719032953.18679-1-xujianghui@cdjrlc.com>
2023-07-19 6:50 ` [PATCH] napi: remove spaces after '(' sunran001
2023-07-23 15:13 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).