From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC16C001DF for ; Sun, 23 Jul 2023 15:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229509AbjGWPNZ (ORCPT ); Sun, 23 Jul 2023 11:13:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbjGWPNY (ORCPT ); Sun, 23 Jul 2023 11:13:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 513BBFE; Sun, 23 Jul 2023 08:13:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C570B60DB7; Sun, 23 Jul 2023 15:13:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A88A4C433C9; Sun, 23 Jul 2023 15:13:18 +0000 (UTC) Date: Sun, 23 Jul 2023 11:13:16 -0400 From: Steven Rostedt To: sunran001@208suo.com Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] napi: remove spaces after '(' Message-ID: <20230723111317.7aadddc0@gandalf.local.home> In-Reply-To: References: <20230719032953.18679-1-xujianghui@cdjrlc.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Wed, 19 Jul 2023 14:50:11 +0800 sunran001@208suo.com wrote: > Fix four occurrences of the checkpatch error: > > ERROR: space prohibited after that open parenthesis '(' > > Signed-off-by: Ran Sun > --- > include/trace/events/napi.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/napi.h b/include/trace/events/napi.h > index 6678cf8b235b..98fb9e0d2219 100644 > --- a/include/trace/events/napi.h > +++ b/include/trace/events/napi.h > @@ -18,10 +18,10 @@ TRACE_EVENT(napi_poll, > TP_ARGS(napi, work, budget), > > TP_STRUCT__entry( > - __field( struct napi_struct *, napi) > - __string( dev_name, napi->dev ? napi->dev->name : NO_DEV) > - __field( int, work) > - __field( int, budget) > + __field(struct napi_struct *, napi) > + __string(dev_name, napi->dev ? napi->dev->name : NO_DEV) > + __field(int, work) > + __field(int, budget) NACK! Which version looks better? checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM! -- Steve > ), > > TP_fast_assign(