From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org,
samitolvanen@google.com, x86@kernel.org,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] x86/retpoline,kprobes: Fix the [__indirect_thunk_start, ..end] range
Date: Sun, 30 Jul 2023 00:14:35 +0900 [thread overview]
Message-ID: <20230730001435.ed2b12649d5c98d42981daf6@kernel.org> (raw)
In-Reply-To: <20230711091952.27944-1-petr.pavlu@suse.com>
Hi Peter,
Can you pick this series to tip tree?
I think, these affect to x86 arch code.
Thank you,
On Tue, 11 Jul 2023 11:19:50 +0200
Petr Pavlu <petr.pavlu@suse.com> wrote:
> Fix problems with an output position of thunk sections and the
> associated definition of range [__indirect_thunk_start,
> __indirect_thunk_end] which affects the kprobes optimization.
>
> Initial v1 of the series kept the mentioned range but it turns out the
> logic which uses it is not necessary so it is removed altogether.
>
> Changes since v1 [1]:
> - Drop the patch which moved the return thunk out of
> [__indirect_thunk_start, ..end] and instead replace it with a removal
> of the kprobes optimization check which looked for calls to indirect
> thunks.
> - Slightly adjust the commit message for the first patch, to better
> match the new second patch.
>
> [1] https://lore.kernel.org/lkml/20230705081547.25130-1-petr.pavlu@suse.com/
>
> Petr Pavlu (2):
> x86/retpoline,kprobes: Fix position of thunk sections with
> CONFIG_LTO_CLANG
> x86/retpoline,kprobes: Skip optprobe check for indirect jumps with
> retpolines and IBT
>
> arch/x86/include/asm/nospec-branch.h | 3 ---
> arch/x86/kernel/kprobes/opt.c | 40 +++++++++++-----------------
> arch/x86/kernel/vmlinux.lds.S | 4 +--
> arch/x86/lib/retpoline.S | 4 +--
> tools/perf/util/thread-stack.c | 4 +--
> 5 files changed, 20 insertions(+), 35 deletions(-)
>
> --
> 2.35.3
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-07-29 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 9:19 [PATCH v2 0/2] x86/retpoline,kprobes: Fix the [__indirect_thunk_start, ..end] range Petr Pavlu
2023-07-11 9:19 ` [PATCH v2 1/2] x86/retpoline,kprobes: Fix position of thunk sections with CONFIG_LTO_CLANG Petr Pavlu
2023-07-11 9:19 ` [PATCH v2 2/2] x86/retpoline,kprobes: Skip optprobe check for indirect jumps with retpolines and IBT Petr Pavlu
2023-07-11 12:33 ` Masami Hiramatsu
2023-07-29 15:14 ` Masami Hiramatsu [this message]
2023-07-31 10:22 ` [PATCH v2 0/2] x86/retpoline,kprobes: Fix the [__indirect_thunk_start, ..end] range Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230730001435.ed2b12649d5c98d42981daf6@kernel.org \
--to=mhiramat@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).