From: Steven Rostedt <rostedt@goodmis.org>
To: Sishuai Gong <sishuai.system@gmail.com>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracefs: avoid setting i_mode to a temp value
Date: Thu, 17 Aug 2023 20:00:44 -0400 [thread overview]
Message-ID: <20230817200044.373f9655@gandalf.local.home> (raw)
In-Reply-To: <A9B746AC-DF36-4ED3-BBA3-2EEC1BA166C8@gmail.com>
On Thu, 17 Aug 2023 19:47:34 -0400
Sishuai Gong <sishuai.system@gmail.com> wrote:
> > Can you produce this race?
> This data race was detected when I was testing the kernel (e.g., fuzzing)
> but I did not make the attempt to reproduce it.
Now, I'm curious to what exactly is this fixing? The intermediate value is
the S_IALLUGO bits cleared. Doesn't that mean that nothing has permission?
It's not a big deal if that's the case, as it just means things are locked
down a bit more than normal.
My question is, do we really care, and why should we?
-- Steve
next prev parent reply other threads:[~2023-08-18 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 0:59 [PATCH] tracefs: avoid setting i_mode to a temp value Sishuai Gong
2023-08-16 19:52 ` Steven Rostedt
2023-08-17 23:47 ` Sishuai Gong
2023-08-18 0:00 ` Steven Rostedt [this message]
2023-08-18 0:05 ` Sishuai Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817200044.373f9655@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=sishuai.system@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).