From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A19C678DC for ; Fri, 18 Aug 2023 00:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356486AbjHRABm (ORCPT ); Thu, 17 Aug 2023 20:01:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356504AbjHRABO (ORCPT ); Thu, 17 Aug 2023 20:01:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 556803C30; Thu, 17 Aug 2023 17:01:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8AF8660E8A; Fri, 18 Aug 2023 00:00:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64F3BC433C8; Fri, 18 Aug 2023 00:00:41 +0000 (UTC) Date: Thu, 17 Aug 2023 20:00:44 -0400 From: Steven Rostedt To: Sishuai Gong Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] tracefs: avoid setting i_mode to a temp value Message-ID: <20230817200044.373f9655@gandalf.local.home> In-Reply-To: References: <10CFECF7-B9FC-4562-A445-4811F4C27655@gmail.com> <20230816155245.6ead4384@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Thu, 17 Aug 2023 19:47:34 -0400 Sishuai Gong wrote: > > Can you produce this race? > This data race was detected when I was testing the kernel (e.g., fuzzing) > but I did not make the attempt to reproduce it. Now, I'm curious to what exactly is this fixing? The intermediate value is the S_IALLUGO bits cleared. Doesn't that mean that nothing has permission? It's not a big deal if that's the case, as it just means things are locked down a bit more than normal. My question is, do we really care, and why should we? -- Steve