From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Zheng Yejian <zhengyejian1@huawei.com>, <laijs@cn.fujitsu.com>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tracing: Introduce pipe_cpumask to avoid race on trace_pipes
Date: Sun, 20 Aug 2023 22:33:01 -0400 [thread overview]
Message-ID: <20230820223301.1a013170@rorschach.local.home> (raw)
In-Reply-To: <20230821111954.8ca184e9fba62940825eb0e0@kernel.org>
On Mon, 21 Aug 2023 11:19:54 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> Ah, this caused a drop. errno can be EAGAIN even if rlen > 0.
> I've fixed this and that works.
> BTW, I think this virtio-trace would be better to move under
> tools/tracing because it is a tracing tool.
I'm fine with that, as where it is, I'm very unfamiliar with this tool.
It is likely not taking advantage of all the tracing tooling we
have. I actually never even used it.
-- Steve
next prev parent reply other threads:[~2023-08-21 2:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 12:39 [PATCH] tracing: Fix race when concurrently splice_read trace_pipe Zheng Yejian
2023-08-11 11:42 ` Masami Hiramatsu
2023-08-11 12:37 ` Zheng Yejian
2023-08-11 19:24 ` Steven Rostedt
2023-08-12 2:22 ` Zheng Yejian
2023-08-12 21:08 ` Steven Rostedt
2023-08-16 19:23 ` Steven Rostedt
2023-08-17 11:50 ` [RFC PATCH] tracing: Introduce pipe_cpumask to avoid race on trace_pipes Zheng Yejian
2023-08-17 14:13 ` Steven Rostedt
2023-08-18 1:38 ` Zheng Yejian
2023-08-18 1:43 ` Steven Rostedt
2023-08-18 2:26 ` [PATCH v2] " Zheng Yejian
2023-08-18 5:03 ` Masami Hiramatsu
2023-08-18 13:41 ` Steven Rostedt
2023-08-18 14:23 ` Masami Hiramatsu
2023-08-18 15:53 ` Steven Rostedt
2023-08-19 1:42 ` Masami Hiramatsu
2023-08-20 13:18 ` Masami Hiramatsu
2023-08-21 2:19 ` Masami Hiramatsu
2023-08-21 2:33 ` Steven Rostedt [this message]
2023-08-21 9:21 ` Masami Hiramatsu
2023-08-21 15:17 ` Steven Rostedt
2023-08-21 22:32 ` Masami Hiramatsu
2023-08-11 19:25 ` [PATCH] tracing: Fix race when concurrently splice_read trace_pipe Steven Rostedt
2023-08-12 1:45 ` Zheng Yejian
2023-08-12 20:47 ` Masami Hiramatsu
2023-08-12 7:38 ` Zheng Yejian
2023-08-13 1:13 ` Steven Rostedt
2023-08-13 16:41 ` Linus Torvalds
2023-08-14 20:16 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820223301.1a013170@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).