From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A03CDEE4996 for ; Mon, 21 Aug 2023 02:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232508AbjHUCdI (ORCPT ); Sun, 20 Aug 2023 22:33:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbjHUCdH (ORCPT ); Sun, 20 Aug 2023 22:33:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43F029C; Sun, 20 Aug 2023 19:33:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD4E761772; Mon, 21 Aug 2023 02:33:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85614C433C7; Mon, 21 Aug 2023 02:33:04 +0000 (UTC) Date: Sun, 20 Aug 2023 22:33:01 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Zheng Yejian , , , Subject: Re: [PATCH v2] tracing: Introduce pipe_cpumask to avoid race on trace_pipes Message-ID: <20230820223301.1a013170@rorschach.local.home> In-Reply-To: <20230821111954.8ca184e9fba62940825eb0e0@kernel.org> References: <20230817115057.1637676-1-zhengyejian1@huawei.com> <20230818022645.1948314-1-zhengyejian1@huawei.com> <20230818140309.b0a720afa87b05a2b7b27315@kernel.org> <20230818094128.7cf1d58b@gandalf.local.home> <20230818232301.902ad9319569379ebd7df557@kernel.org> <20230818115322.3dfda470@gandalf.local.home> <20230819104257.80203c3916509cc9eb9327c1@kernel.org> <20230821111954.8ca184e9fba62940825eb0e0@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, 21 Aug 2023 11:19:54 +0900 Masami Hiramatsu (Google) wrote: > Ah, this caused a drop. errno can be EAGAIN even if rlen > 0. > I've fixed this and that works. > BTW, I think this virtio-trace would be better to move under > tools/tracing because it is a tracing tool. I'm fine with that, as where it is, I'm very unfamiliar with this tool. It is likely not taking advantage of all the tracing tooling we have. I actually never even used it. -- Steve