From: Steven Rostedt <rostedt@goodmis.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-docs@vger.kernel.org
Subject: Re: [PATCH] tracefs: Fix kernel-doc warnings
Date: Mon, 21 Aug 2023 10:49:01 -0400 [thread overview]
Message-ID: <20230821104901.1e15079e@gandalf.local.home> (raw)
In-Reply-To: <ZONu6+WAjUXNKn7l@casper.infradead.org>
On Mon, 21 Aug 2023 15:04:27 +0100
Matthew Wilcox <willy@infradead.org> wrote:
> On Mon, Aug 21, 2023 at 10:01:46AM -0400, Steven Rostedt wrote:
> > This is one of the cases I disagree with kerneldoc. I mean, this isn't a
> > public structure (it's only in this file) so I don't expect it to be
> > parsed. These three fields act as one. Having them in the kerneldoc format
> > above makes them look as three distinct fields. Perhaps the solution is to
> > get rid of the starting /** so that it's no longer in kerneldoc format.
>
> Yes, take it out of kernel-doc's purview by removing that second *.
> I don't think you need me to send a v2 patch to do that ;-)
Yep, I'll do it.
Thanks!
-- Steve
prev parent reply other threads:[~2023-08-21 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 20:14 [PATCH] tracefs: Fix kernel-doc warnings Matthew Wilcox (Oracle)
2023-08-21 14:01 ` Steven Rostedt
2023-08-21 14:04 ` Matthew Wilcox
2023-08-21 14:49 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821104901.1e15079e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-docs@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).