From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf@vger.kernel.org, Sven Schnelle <svens@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH v5 0/9] tracing: Improbe BTF support on probe events
Date: Tue, 22 Aug 2023 00:09:39 +0900 [thread overview]
Message-ID: <20230822000939.81897c0c904934bfb9156a59@kernel.org> (raw)
In-Reply-To: <169137686814.271367.11218568219311636206.stgit@devnote2>
Hi Steve,
Can you review this series?
I would like to push this to for-next.
Thank you,
On Mon, 7 Aug 2023 11:54:28 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> Hi,
>
> Here is the 5th version of series to improve the BTF support on probe events.
> The previous series is here:
>
> https://lore.kernel.org/all/169078860386.173706.3091034523220945605.stgit@devnote2/
>
> This version introduces kernel/trace/trace_btf.c to separate the btf generic
> functions. These functions will be moved to btf.c next merge window.
> This fixes the member-search function to return the bit-offset of the
> parent anonymous union/structure. Thus the caller can calculate the real
> bit-offset from the root data structure.
> This also fixes the ftrace selftest issue which fails if the kernel
> supports only BTF args but not support field access.
>
> This series can be applied on top of "probes/core" branch of
> https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/
>
> You can also get this series from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git topic/fprobe-event-ext
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (Google) (9):
> tracing/probes: Support BTF argument on module functions
> tracing/probes: Move finding func-proto API and getting func-param API to trace_btf
> tracing/probes: Add a function to search a member of a struct/union
> tracing/probes: Support BTF based data structure field access
> tracing/probes: Support BTF field access from $retval
> tracing/probes: Add string type check with BTF
> tracing/fprobe-event: Assume fprobe is a return event by $retval
> selftests/ftrace: Add BTF fields access testcases
> Documentation: tracing: Update fprobe event example with BTF field
>
>
> Documentation/trace/fprobetrace.rst | 64 ++-
> include/linux/btf.h | 1
> kernel/bpf/btf.c | 2
> kernel/trace/Makefile | 1
> kernel/trace/trace.c | 3
> kernel/trace/trace_btf.c | 109 ++++
> kernel/trace/trace_btf.h | 11
> kernel/trace/trace_eprobe.c | 4
> kernel/trace/trace_fprobe.c | 59 ++
> kernel/trace/trace_kprobe.c | 1
> kernel/trace/trace_probe.c | 499 +++++++++++++++-----
> kernel/trace/trace_probe.h | 27 +
> kernel/trace/trace_uprobe.c | 1
> .../ftrace/test.d/dynevent/add_remove_btfarg.tc | 20 +
> .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 10
> 15 files changed, 637 insertions(+), 175 deletions(-)
> create mode 100644 kernel/trace/trace_btf.c
> create mode 100644 kernel/trace/trace_btf.h
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-08-21 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 2:54 [PATCH v5 0/9] tracing: Improbe BTF support on probe events Masami Hiramatsu (Google)
2023-08-07 2:54 ` [PATCH v5 1/9] tracing/probes: Support BTF argument on module functions Masami Hiramatsu (Google)
2023-08-07 2:54 ` [PATCH v5 2/9] tracing/probes: Move finding func-proto API and getting func-param API to trace_btf Masami Hiramatsu (Google)
2023-08-07 2:54 ` [PATCH v5 3/9] tracing/probes: Add a function to search a member of a struct/union Masami Hiramatsu (Google)
2023-08-22 13:37 ` Steven Rostedt
2023-08-22 14:36 ` Masami Hiramatsu
2023-08-07 2:55 ` [PATCH v5 4/9] tracing/probes: Support BTF based data structure field access Masami Hiramatsu (Google)
2023-08-07 2:55 ` [PATCH v5 5/9] tracing/probes: Support BTF field access from $retval Masami Hiramatsu (Google)
2023-08-07 2:55 ` [PATCH v5 6/9] tracing/probes: Add string type check with BTF Masami Hiramatsu (Google)
2023-08-07 2:55 ` [PATCH v5 7/9] tracing/fprobe-event: Assume fprobe is a return event by $retval Masami Hiramatsu (Google)
2023-08-07 2:55 ` [PATCH v5 8/9] selftests/ftrace: Add BTF fields access testcases Masami Hiramatsu (Google)
2023-08-07 2:55 ` [PATCH v5 9/9] Documentation: tracing: Update fprobe event example with BTF field Masami Hiramatsu (Google)
2023-08-21 15:09 ` Masami Hiramatsu [this message]
2023-08-22 14:07 ` [PATCH v5 0/9] tracing: Improbe BTF support on probe events Steven Rostedt
2023-08-22 14:38 ` Masami Hiramatsu
2023-08-22 14:46 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822000939.81897c0c904934bfb9156a59@kernel.org \
--to=mhiramat@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).